Bug 160848

Summary:

[Cocoa] Remove deprecated _WKFormDelegate

Product:

WebKit

Reporter:

mitz

Component:

WebKit API

Assignee:

mitz

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, sam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Remove _WKFormDelegate	none

Description mitz 2016-08-14 16:04:18 PDT

Patch forthcoming.

Comment 1 mitz 2016-08-14 16:07:04 PDT

Created attachment 286037 [details]
Remove _WKFormDelegate

Comment 2 Anders Carlsson 2016-08-14 16:41:33 PDT

Comment on attachment 286037 [details]
Remove _WKFormDelegate

View in context: https://bugs.webkit.org/attachment.cgi?id=286037&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:4655
> +@implementation WKWebView (WKBinaryCompatibilityWithIOS10)
> +
> +- (id <_WKInputDelegate>)_formDelegate
> +{
> +    return self._inputDelegate;
> +}
> +
> +- (void)_setFormDelegate:(id <_WKInputDelegate>)formDelegate
> +{
> +    self._inputDelegate = formDelegate;
> +}

Can we put this inside an #ifdef so it'll be easier to see when we can remove it?

Comment 3 WebKit Commit Bot 2016-08-14 17:04:05 PDT

Comment on attachment 286037 [details]
Remove _WKFormDelegate

Clearing flags on attachment: 286037

Committed r204458: <http://trac.webkit.org/changeset/204458>

Comment 4 WebKit Commit Bot 2016-08-14 17:04:09 PDT

All reviewed patches have been landed.  Closing bug.