Bug 160819

Summary: 'compatMode' property should be on Document, not HTMLDocument
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin, dbates, esprehn+autocc, gyuyoung.kim, kondapallykalyan, rniwa, sam
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2016-08-12 14:05:24 PDT
'compatMode' property should be on Document, not HTMLDocument: - https://dom.spec.whatwg.org/#dom-document-compatmode WebKit had it on both. Firefox and Chrome have it on Document only.
Attachments
Patch (3.61 KB, patch)
2016-08-12 14:06 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (3.73 KB, patch)
2016-08-13 16:23 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-08-12 14:06:38 PDT
Created attachment 285944 [details] Patch
WebKit Commit Bot
Comment 2 2016-08-13 16:19:29 PDT
Comment on attachment 285944 [details] Patch Rejecting attachment 285944 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 285944, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 204448 = a3f112c9a0a29bfd4ead244ab8b6b187144ca5da r204449 = c3567caf1cf730e94ab48be897a55d8cf2dc611e r204450 = 8104afab50641d0d30bb419f1d267e318caf205d Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/1866281
Chris Dumez
Comment 3 2016-08-13 16:23:47 PDT
Created attachment 286009 [details] Patch
WebKit Commit Bot
Comment 4 2016-08-13 17:11:54 PDT
Comment on attachment 286009 [details] Patch Clearing flags on attachment: 286009 Committed r204451: <http://trac.webkit.org/changeset/204451>
WebKit Commit Bot
Comment 5 2016-08-13 17:11:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.