Bug 160819 - 'compatMode' property should be on Document, not HTMLDocument
Summary: 'compatMode' property should be on Document, not HTMLDocument
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2016-08-12 14:05 PDT by Chris Dumez
Modified: 2016-08-13 17:11 PDT (History)
9 users (show)

See Also:

Attachments
Patch (3.61 KB, patch)
2016-08-12 14:06 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (3.73 KB, patch)
2016-08-13 16:23 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-08-12 14:05:24 PDT 
'compatMode' property should be on Document, not HTMLDocument:
- https://dom.spec.whatwg.org/#dom-document-compatmode

WebKit had it on both. Firefox and Chrome have it on Document only.
Comment 1 Chris Dumez 2016-08-12 14:06:38 PDT 
Created attachment 285944 [details]
Patch
Comment 2 WebKit Commit Bot 2016-08-13 16:19:29 PDT 
Comment on attachment 285944 [details]
Patch

Rejecting attachment 285944 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 285944, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
    -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 204448 = a3f112c9a0a29bfd4ead244ab8b6b187144ca5da
r204449 = c3567caf1cf730e94ab48be897a55d8cf2dc611e
r204450 = 8104afab50641d0d30bb419f1d267e318caf205d
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/1866281
Comment 3 Chris Dumez 2016-08-13 16:23:47 PDT 
Created attachment 286009 [details]
Patch
Comment 4 WebKit Commit Bot 2016-08-13 17:11:54 PDT 
Comment on attachment 286009 [details]
Patch

Clearing flags on attachment: 286009

Committed r204451: <http://trac.webkit.org/changeset/204451>
Comment 5 WebKit Commit Bot 2016-08-13 17:11:59 PDT 
All reviewed patches have been landed.  Closing bug.