Bug 160815

Summary: Add HashCountedSet to TestWTFLibrary target
Product: WebKit Reporter: John Wilander <wilander>
Component: Tools / TestsAssignee: John Wilander <wilander>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, dbates, lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

John Wilander
Reported 2016-08-12 13:12:47 PDT
HashCountedSet is currently not part of any target and thus not run. It should be part of the TestWTFLibrary target.
Attachments
Patch (2.50 KB, patch)
2016-08-12 13:16 PDT, John Wilander 		no flags
DetailsFormatted DiffDiff
Patch (5.60 KB, patch)
2016-08-12 14:10 PDT, John Wilander 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
John Wilander
Comment 1 2016-08-12 13:13:23 PDT
HashCountedSet tests in TestWebKitAPI that is.
John Wilander
Comment 2 2016-08-12 13:14:29 PDT
Changing component to Tools / Tests.
John Wilander
Comment 3 2016-08-12 13:16:48 PDT
Created attachment 285938 [details] Patch
Daniel Bates
Comment 4 2016-08-12 13:36:54 PDT
Comment on attachment 285938 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285938&action=review HashCountedSet.cpp is already in Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj (Is it in the wrong place?) See <https://trac.webkit.org/browser/trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj#L854> and <https://trac.webkit.org/browser/trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj#L1611>. > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:2105 > + 6BFD29481D5E642E008EC968 /* HashCountedSet.cpp in Sources */, Please insert this item such that it is in sorted order according to the UNIX sort command.
Daniel Bates
Comment 5 2016-08-12 13:40:19 PDT
(In reply to comment #4) > Comment on attachment 285938 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=285938&action=review > > HashCountedSet.cpp is already in > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj (Is it in the > wrong place?) See > <https://trac.webkit.org/browser/trunk/Tools/TestWebKitAPI/TestWebKitAPI. > xcodeproj/project.pbxproj#L854> and > <https://trac.webkit.org/browser/trunk/Tools/TestWebKitAPI/TestWebKitAPI. > xcodeproj/project.pbxproj#L1611>. > Disregard this remark. As you mentioned in comment 0 HashCountedSet.cpp is not part of the target TestWTFLibrary.
John Wilander
Comment 6 2016-08-12 14:10:43 PDT
Created attachment 285946 [details] Patch
John Wilander
Comment 7 2016-08-12 14:15:21 PDT
Thanks! I sorted that whole section as we discussed.
WebKit Commit Bot
Comment 8 2016-08-12 16:10:11 PDT
Comment on attachment 285946 [details] Patch Clearing flags on attachment: 285946 Committed r204430: <http://trac.webkit.org/changeset/204430>
WebKit Commit Bot
Comment 9 2016-08-12 16:10:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.