Bug 160810

Summary:

Web Inspector: Command-Shift-O causes infinite loop if web page has frames

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Blocker

CC:

bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	joepeck: review+
Patch	nvasilyev: review-, nvasilyev: commit-queue-
Patch	none

Description Nikita Vasilyev 2016-08-12 11:55:34 PDT

Steps:
1. Open Web Inspector on this page.
2. Press Command-Shift-O

Comment 1 Radar WebKit Bug Importer 2016-08-12 11:56:03 PDT

<rdar://problem/27827557>

Comment 2 Nikita Vasilyev 2016-08-12 11:59:48 PDT

Created attachment 285924 [details]
Patch

Comment 3 Joseph Pecoraro 2016-08-12 12:10:53 PDT

Comment on attachment 285924 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285924&action=review

r=me

> Source/WebInspectorUI/ChangeLog:10
> +        "frame" doens't change inside the loop.

Typo: "doesn't"

Comment 4 Nikita Vasilyev 2016-08-12 12:24:18 PDT

Created attachment 285928 [details]
Patch

Comment 5 Nikita Vasilyev 2016-08-12 12:26:03 PDT

Created attachment 285929 [details]
Patch

Comment 6 WebKit Commit Bot 2016-08-12 13:04:31 PDT

The commit-queue encountered the following flaky tests while processing attachment 285929 [details]:

transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com)
The commit-queue is continuing to process your patch.

Comment 7 WebKit Commit Bot 2016-08-12 13:04:33 PDT

The commit-queue encountered the following flaky tests while processing attachment 285929 [details]:

The commit-queue is continuing to process your patch.

Comment 8 WebKit Commit Bot 2016-08-12 15:34:26 PDT

Comment on attachment 285929 [details]
Patch

Clearing flags on attachment: 285929

Committed r204428: <http://trac.webkit.org/changeset/204428>

Comment 9 WebKit Commit Bot 2016-08-12 15:34:30 PDT

All reviewed patches have been landed.  Closing bug.