Bug 160810

Summary: Web Inspector: Command-Shift-O causes infinite loop if web page has frames
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Blocker CC: bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P1 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
joepeck: review+
Patch
nvasilyev: review-, nvasilyev: commit-queue-
Patch none

Nikita Vasilyev
Reported 2016-08-12 11:55:34 PDT
Steps: 1. Open Web Inspector on this page. 2. Press Command-Shift-O
Attachments
Patch (1.44 KB, patch)
2016-08-12 11:59 PDT, Nikita Vasilyev 		joepeck: review+
DetailsFormatted DiffDiff
Patch (1.44 KB, patch)
2016-08-12 12:24 PDT, Nikita Vasilyev 		nvasilyev: review-
nvasilyev: commit-queue-
DetailsFormatted DiffDiff
Patch (1.44 KB, patch)
2016-08-12 12:26 PDT, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-08-12 11:56:03 PDT
<rdar://problem/27827557>
Nikita Vasilyev
Comment 2 2016-08-12 11:59:48 PDT
Created attachment 285924 [details] Patch
Joseph Pecoraro
Comment 3 2016-08-12 12:10:53 PDT
Comment on attachment 285924 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285924&action=review r=me > Source/WebInspectorUI/ChangeLog:10 > + "frame" doens't change inside the loop. Typo: "doesn't"
Nikita Vasilyev
Comment 4 2016-08-12 12:24:18 PDT
Created attachment 285928 [details] Patch
Nikita Vasilyev
Comment 5 2016-08-12 12:26:03 PDT
Created attachment 285929 [details] Patch
WebKit Commit Bot
Comment 6 2016-08-12 13:04:31 PDT
The commit-queue encountered the following flaky tests while processing attachment 285929 [details]: transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2016-08-12 13:04:33 PDT
The commit-queue encountered the following flaky tests while processing attachment 285929 [details]: The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 8 2016-08-12 15:34:26 PDT
Comment on attachment 285929 [details] Patch Clearing flags on attachment: 285929 Committed r204428: <http://trac.webkit.org/changeset/204428>
WebKit Commit Bot
Comment 9 2016-08-12 15:34:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.