Bug 160810 - Web Inspector: Command-Shift-O causes infinite loop if web page has frames
Summary: Web Inspector: Command-Shift-O causes infinite loop if web page has frames
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P1 Blocker
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-08-12 11:55 PDT by Nikita Vasilyev
Modified: 2016-08-12 15:34 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.44 KB, patch)
2016-08-12 11:59 PDT, Nikita Vasilyev 		joepeck: review+
Details | Formatted Diff | Diff
Patch (1.44 KB, patch)
2016-08-12 12:24 PDT, Nikita Vasilyev 		nvasilyev: review-
nvasilyev: commit-queue-
Details | Formatted Diff | Diff
Patch (1.44 KB, patch)
2016-08-12 12:26 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2016-08-12 11:55:34 PDT 
Steps:
1. Open Web Inspector on this page.
2. Press Command-Shift-O
Comment 1 Radar WebKit Bug Importer 2016-08-12 11:56:03 PDT 
<rdar://problem/27827557>
Comment 2 Nikita Vasilyev 2016-08-12 11:59:48 PDT 
Created attachment 285924 [details]
Patch
Comment 3 Joseph Pecoraro 2016-08-12 12:10:53 PDT 
Comment on attachment 285924 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285924&action=review

r=me

> Source/WebInspectorUI/ChangeLog:10
> +        "frame" doens't change inside the loop.

Typo: "doesn't"
Comment 4 Nikita Vasilyev 2016-08-12 12:24:18 PDT 
Created attachment 285928 [details]
Patch
Comment 5 Nikita Vasilyev 2016-08-12 12:26:03 PDT 
Created attachment 285929 [details]
Patch
Comment 6 WebKit Commit Bot 2016-08-12 13:04:31 PDT 
The commit-queue encountered the following flaky tests while processing attachment 285929 [details]:

transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2016-08-12 13:04:33 PDT 
The commit-queue encountered the following flaky tests while processing attachment 285929 [details]:

The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2016-08-12 15:34:26 PDT 
Comment on attachment 285929 [details]
Patch

Clearing flags on attachment: 285929

Committed r204428: <http://trac.webkit.org/changeset/204428>
Comment 9 WebKit Commit Bot 2016-08-12 15:34:30 PDT 
All reviewed patches have been landed.  Closing bug.