Bug 160807

Summary: Add test for fixed nullptr deref error
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: MathMLAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, dbarton, dbates, fred.wang, ryanhaddad
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Brent Fulgham
Reported 2016-08-12 10:47:05 PDT
This bug just documents the addition of a test case that will help us avoid a nullptr dereference crash we encountered in MathML a few years ago.
Attachments
Patch (1.56 KB, patch)
2016-08-12 10:50 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2016-08-12 10:50:46 PDT
Created attachment 285919 [details] Patch
Brent Fulgham
Comment 2 2016-08-12 11:51:35 PDT
The Windows failure is unrelated to this patch.
Brent Fulgham
Comment 3 2016-08-12 11:53:55 PDT
Committed in r204415 <https://trac.webkit.org/changeset/204415>.
Daniel Bates
Comment 4 2016-08-12 12:52:47 PDT
Comment on attachment 285919 [details] Patch Clearing review flag as this change was committed per comment #3.
Daniel Bates
Comment 5 2016-08-12 12:53:38 PDT
(In reply to comment #0) > This bug just documents the addition of a test case that will help us avoid > a nullptr dereference crash we encountered in MathML a few years ago. Do we know the bug/changeset that fixed the MathML bug? If so, we should mark this bug as dependent on it.
Frédéric Wang (:fredw)
Comment 6 2016-08-26 23:36:24 PDT
(In reply to comment #5) > (In reply to comment #0) > > This bug just documents the addition of a test case that will help us avoid > > a nullptr dereference crash we encountered in MathML a few years ago. > > Do we know the bug/changeset that fixed the MathML bug? If so, we should > mark this bug as dependent on it. A big refactoring has happened recently: http://trac.webkit.org/wiki/MathML/Early_2016_Refactoring#Phase1 My guess would be r202168 (bug 153987).
Note You need to log in before you can comment on or make changes to this bug.