Bug 160807

Summary: Add test for fixed nullptr deref error
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: MathMLAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, dbarton, dbates, fred.wang, ryanhaddad
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Brent Fulgham 2016-08-12 10:47:05 PDT 
This bug just documents the addition of a test case that will help us avoid a nullptr dereference crash we encountered in MathML a few years ago.
Comment 1 Brent Fulgham 2016-08-12 10:50:46 PDT 
Created attachment 285919 [details]
Patch
Comment 2 Brent Fulgham 2016-08-12 11:51:35 PDT 
The Windows failure is unrelated to this patch.
Comment 3 Brent Fulgham 2016-08-12 11:53:55 PDT 
Committed in r204415 <https://trac.webkit.org/changeset/204415>.
Comment 4 Daniel Bates 2016-08-12 12:52:47 PDT 
Comment on attachment 285919 [details]
Patch

Clearing review flag as this change was committed per comment #3.
Comment 5 Daniel Bates 2016-08-12 12:53:38 PDT 
(In reply to comment #0)
> This bug just documents the addition of a test case that will help us avoid
> a nullptr dereference crash we encountered in MathML a few years ago.

Do we know the bug/changeset that fixed the MathML bug? If so, we should mark this bug as dependent on it.
Comment 6 Frédéric Wang (:fredw) 2016-08-26 23:36:24 PDT 
(In reply to comment #5)
> (In reply to comment #0)
> > This bug just documents the addition of a test case that will help us avoid
> > a nullptr dereference crash we encountered in MathML a few years ago.
> 
> Do we know the bug/changeset that fixed the MathML bug? If so, we should
> mark this bug as dependent on it.

A big refactoring has happened recently:
http://trac.webkit.org/wiki/MathML/Early_2016_Refactoring#Phase1

My guess would be r202168 (bug 153987).