Bug 160790

Summary: [MediaStream] Add support for OverConstrained Error
Product: WebKit Reporter: George Ruan <gruan>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, jer.noble, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 146746    
Attachments:
Description Flags
Proposed patch.
none
Proposed patch.
none
Rebased patch.
none
Proposed patch. none

George Ruan
Reported 2016-08-11 17:33:29 PDT
https://w3c.github.io/mediacapture-main/#overconstrainederror-object Add support for the OverConstrainedError Object. Blocks https://bugs.webkit.org/show_bug.cgi?id=146746, since it is a part of the getUserMedia() algorithm, step 6.3: https://w3c.github.io/mediacapture-main/#dom-mediadevices-getusermedia.
Attachments
Proposed patch. (18.20 KB, patch)
2016-08-24 11:06 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Proposed patch. (24.97 KB, patch)
2016-08-24 11:41 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Rebased patch. (19.49 KB, text/plain)
2016-08-24 12:40 PDT, Eric Carlson 		no flags
Details
Proposed patch. (19.39 KB, patch)
2016-08-24 13:58 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-08-11 17:34:43 PDT
<rdar://problem/27815715>
George Ruan
Comment 2 2016-08-12 13:51:48 PDT
*** Bug 157839 has been marked as a duplicate of this bug. ***
Eric Carlson
Comment 3 2016-08-24 10:55:34 PDT
*** Bug 161146 has been marked as a duplicate of this bug. ***
Eric Carlson
Comment 4 2016-08-24 10:57:19 PDT
The spec says that it should be possible to create an OverconstrainedError by calling it as a function as well as with new: "When OverconstrainedError is called as a function rather than as a constructor, it creates and initializes a new OverconstrainedError object". WebKit's bindings generator doesn't support this so we won't be able to do that in the first implementation.
Eric Carlson
Comment 5 2016-08-24 11:06:30 PDT
Created attachment 286870 [details] Proposed patch.
Eric Carlson
Comment 6 2016-08-24 11:41:23 PDT
Created attachment 286875 [details] Proposed patch.
Eric Carlson
Comment 7 2016-08-24 12:40:44 PDT
Created attachment 286881 [details] Rebased patch.
Eric Carlson
Comment 8 2016-08-24 13:58:43 PDT
Created attachment 286889 [details] Proposed patch.
WebKit Commit Bot
Comment 9 2016-08-24 14:57:12 PDT
Comment on attachment 286889 [details] Proposed patch. Clearing flags on attachment: 286889 Committed r204935: <http://trac.webkit.org/changeset/204935>
Note You need to log in before you can comment on or make changes to this bug.