Bug 160788

Summary: Add WK2 ExperimentalFeature support to MiniBrowser
Product: WebKit Reporter: Brady Eidson <beidson>
Component: Tools / TestsAssignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, lforschler, rniwa, ryanhaddad, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch achristensen: review+

Description Brady Eidson 2016-08-11 17:22:42 PDT 
Add WK2 ExperimentalFeature support to MiniBrowser
Comment 1 Brady Eidson 2016-08-11 17:28:27 PDT 
Created attachment 285873 [details]
Patch
Comment 2 Brady Eidson 2016-08-11 17:28:58 PDT 
Forgot to mention, also makes Gamepads be an experimental feature.
Comment 3 Alex Christensen 2016-08-11 17:33:35 PDT 
Comment on attachment 285873 [details]
Patch

r+, these should be separate patches.
Comment 5 Ryosuke Niwa 2016-08-11 22:29:35 PDT 
It looks like this patch broke 32-bit Mac builds in which _WKExperimentalFeature is not defined. Maybe WK_API_ENABLED is false there?
Comment 6 Brady Eidson 2016-08-12 08:42:02 PDT 
(In reply to comment #5)
> It looks like this patch broke 32-bit Mac builds in which
> _WKExperimentalFeature is not defined. Maybe WK_API_ENABLED is false there?

That's accurate.

Fixing.
Comment 7 Brady Eidson 2016-08-12 08:57:22 PDT 
Attempted fix in https://trac.webkit.org/changeset/204411