Align Range.surroundContents() with the latest DOM specification

• Component: DOM
• Status: RESOLVED FIXED

[Chris Dumez]

Align Range.surroundContents() with the latest DOM specification:
- https://dom.spec.whatwg.org/#dom-range-surroundcontents

This would get us much closer to Firefox's behavior.

[Chris Dumez]

Created attachment 285850 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 285850 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285850&action=review

> LayoutTests/platform/mac/fast/dom/Range/surroundContents-1-expected.txt:8
>            text run at (0,0) width 564: "This tests for HIERARCHY_REQUEST_ERRs when calling Range::surroundContents."

Can we convert this test to a dump-as-markup.js test?

[Build Bot]

Comment on attachment 285850 [details]
Patch

Attachment 285850 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1853617

New failing tests:
fast/dom/Range/surroundContents-1.html

[Build Bot]

Created attachment 285855 [details]
Archive of layout-test-results from ews122 for ios-simulator-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-elcapitan-wk2  Platform: Mac OS X 10.11.5

[Chris Dumez]

Created attachment 285856 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 285856 [details]
Patch

Clearing flags on attachment: 285856

Committed r204390: <http://trac.webkit.org/changeset/204390>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.