| Summary: | Don't append result of makeString | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | alecflett, beidson, commit-queue, jsbell | ||||||||
| Priority: | P2 | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Alex Christensen
2016-08-11 11:45:56 PDT
Created attachment 285839 [details]
Patch
Comment on attachment 285839 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285839&action=review > Source/WebCore/Modules/indexeddb/shared/IDBObjectStoreInfo.cpp:134 > + builder.append("Object store: "); You want appendLiteral here. > Source/WebKit2/Shared/Gamepad/GamepadData.cpp:66 > + builder.append(" axes, "); You want appendLiteral here. > Source/WebKit2/Shared/Gamepad/GamepadData.cpp:68 > + builder.append(" buttons\n"); You want appendLiteral here. > Source/WebKit2/Shared/Gamepad/GamepadData.cpp:71 > + builder.append(" Axis "); You want appendLiteral here. > Source/WebKit2/Shared/Gamepad/GamepadData.cpp:73 > + builder.append(": "); You want appendLiteral here. > Source/WebKit2/Shared/Gamepad/GamepadData.cpp:79 > + builder.append(" Button "); You want appendLiteral here. > Source/WebKit2/Shared/Gamepad/GamepadData.cpp:81 > + builder.append(": "); You want appendLiteral here. Created attachment 285842 [details]
Patch
Created attachment 285849 [details]
Patch
Comment on attachment 285849 [details] Patch Clearing flags on attachment: 285849 Committed r204394: <http://trac.webkit.org/changeset/204394> All reviewed patches have been landed. Closing bug. |