Bug 160772

Summary: Don't append result of makeString
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, commit-queue, jsbell
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2016-08-11 11:45:56 PDT
Don't append result of makeString
Attachments
Patch (7.85 KB, patch)
2016-08-11 11:49 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (33.67 KB, patch)
2016-08-11 12:09 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (30.74 KB, patch)
2016-08-11 13:34 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2016-08-11 11:49:00 PDT
Created attachment 285839 [details] Patch
Sam Weinig
Comment 2 2016-08-11 11:59:02 PDT
Comment on attachment 285839 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285839&action=review > Source/WebCore/Modules/indexeddb/shared/IDBObjectStoreInfo.cpp:134 > + builder.append("Object store: "); You want appendLiteral here. > Source/WebKit2/Shared/Gamepad/GamepadData.cpp:66 > + builder.append(" axes, "); You want appendLiteral here. > Source/WebKit2/Shared/Gamepad/GamepadData.cpp:68 > + builder.append(" buttons\n"); You want appendLiteral here. > Source/WebKit2/Shared/Gamepad/GamepadData.cpp:71 > + builder.append(" Axis "); You want appendLiteral here. > Source/WebKit2/Shared/Gamepad/GamepadData.cpp:73 > + builder.append(": "); You want appendLiteral here. > Source/WebKit2/Shared/Gamepad/GamepadData.cpp:79 > + builder.append(" Button "); You want appendLiteral here. > Source/WebKit2/Shared/Gamepad/GamepadData.cpp:81 > + builder.append(": "); You want appendLiteral here.
Alex Christensen
Comment 3 2016-08-11 12:09:33 PDT
Created attachment 285842 [details] Patch
Alex Christensen
Comment 4 2016-08-11 13:34:49 PDT
Created attachment 285849 [details] Patch
WebKit Commit Bot
Comment 5 2016-08-11 17:35:17 PDT
Comment on attachment 285849 [details] Patch Clearing flags on attachment: 285849 Committed r204394: <http://trac.webkit.org/changeset/204394>
WebKit Commit Bot
Comment 6 2016-08-11 17:35:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.