Bug 160757

Summary: [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, dbates, simon.fraser, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch thorton: review+

Description Simon Fraser (smfr) 2016-08-10 16:31:27 PDT
[iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
Comment 1 Simon Fraser (smfr) 2016-08-10 16:35:19 PDT
Created attachment 285782 [details]
Patch
Comment 2 Tim Horton 2016-08-10 16:54:13 PDT
Comment on attachment 285782 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285782&action=review

> Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:103
> +    const CGFloat statusBarHeight = 20;

Ideally this would use either [[UIApplication sharedApplication] statusBarFrame] or the VC's topLayoutGuide.

> Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:117
> +    UIViewController *viewController = [[UIViewController alloc] initWithNibName:nil bundle:nil];

You can just "init", I think.
Comment 3 Simon Fraser (smfr) 2016-08-10 17:11:33 PDT
https://trac.webkit.org/r204364