| Summary: | [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ap, dbates, simon.fraser, thorton | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2016-08-10 16:31:27 PDT
Created attachment 285782 [details]
Patch
Comment on attachment 285782 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285782&action=review > Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:103 > + const CGFloat statusBarHeight = 20; Ideally this would use either [[UIApplication sharedApplication] statusBarFrame] or the VC's topLayoutGuide. > Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:117 > + UIViewController *viewController = [[UIViewController alloc] initWithNibName:nil bundle:nil]; You can just "init", I think. |