Bug 160749

Summary:

Baseline GetByVal and PutByVal for cache ID stubs need to handle exceptions

Product:

WebKit

Reporter:

Michael Saboff <msaboff>

Component:

JavaScriptCore

Assignee:

Michael Saboff <msaboff>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, keith_miller, mark.lam, saam

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	fpizlo: review+

Description Michael Saboff 2016-08-10 14:31:56 PDT

Both emitGetByValWithCachedId() and emitPutByValWithCachedId() make slow path calls via callOperation().  There are exception checks after the calls in callOperation() and those exception checks need to be linked to the exception handler code for the function that emits the stubs.

Comment 1 Michael Saboff 2016-08-10 14:32:35 PDT

<rdar://problem/27598428>

Comment 2 Michael Saboff 2016-08-10 15:40:34 PDT

Created attachment 285775 [details]
Patch

I tested this patch on Mac X86-64, Mac X86, iOS ARM and ARM64 using the added test.

Comment 3 Michael Saboff 2016-08-10 16:46:33 PDT

Committed r204362: <http://trac.webkit.org/changeset/204362>