Bug 160743

Summary:

Web Inspector: Can't click on the lower half of "S" icon in JavaScript Allocations timeline

Product:

WebKit

Reporter:

Nikita Vasilyev <nvasilyev>

Component:

Web Inspector

Assignee:

Nikita Vasilyev <nvasilyev>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=147236

Attachments:

Description	Flags
[Animated GIF] Bug	none
Patch	timothy: review+, timothy: commit-queue-
[Animated GIF] With patch applied	none
Patch	none

Nikita Vasilyev

Reported 2016-08-10 11:40:22 PDT

Created attachment 285737 [details] [Animated GIF] Bug Because it's covered by <div class="scroll-container">.

Attachments
[Animated GIF] Bug (32.12 KB, image/gif) 2016-08-10 11:40 PDT, Nikita Vasilyev	no flags	Details
Patch (1.48 KB, patch) 2016-08-10 11:50 PDT, Nikita Vasilyev	timothy: review+ timothy: commit-queue-	Details Formatted Diff Diff
[Animated GIF] With patch applied (289.72 KB, image/gif) 2016-08-10 11:54 PDT, Nikita Vasilyev	no flags	Details
Patch (1.55 KB, patch) 2016-08-10 12:07 PDT, Nikita Vasilyev	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2016-08-10 11:40:45 PDT

<rdar://problem/27790098>

Nikita Vasilyev

Comment 2 2016-08-10 11:50:13 PDT

Created attachment 285738 [details] Patch

Timothy Hatcher

Comment 3 2016-08-10 11:53:27 PDT

Comment on attachment 285738 [details] Patch Timelines will soon be able to be reordered, so the Allocations timeline will not always be the last one. Other Timeline record bars should be clickable in the future too. See bug 147236 for an older bug about this. How does this affect the selection boxes? Are the dimmed areas behind or above the S icons? We could land this as a workaround until bug 147236 is fixed. We should add a FIXME comment in that case.

Nikita Vasilyev

Comment 4 2016-08-10 11:54:31 PDT

Created attachment 285739 [details] [Animated GIF] With patch applied

Nikita Vasilyev

Comment 5 2016-08-10 12:07:29 PDT

Created attachment 285741 [details] Patch

WebKit Commit Bot

Comment 6 2016-08-10 12:37:08 PDT

Comment on attachment 285741 [details] Patch Clearing flags on attachment: 285741 Committed r204339: <http://trac.webkit.org/changeset/204339>

WebKit Commit Bot

Comment 7 2016-08-10 12:37:12 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.