Bug 160743

Summary: Web Inspector: Can't click on the lower half of "S" icon in JavaScript Allocations timeline
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=147236
Attachments:
Description Flags
[Animated GIF] Bug
none
Patch
timothy: review+, timothy: commit-queue-
[Animated GIF] With patch applied
none
Patch none

Description Nikita Vasilyev 2016-08-10 11:40:22 PDT
Created attachment 285737 [details]
[Animated GIF] Bug

Because it's covered by <div class="scroll-container">.
Comment 1 Radar WebKit Bug Importer 2016-08-10 11:40:45 PDT
<rdar://problem/27790098>
Comment 2 Nikita Vasilyev 2016-08-10 11:50:13 PDT
Created attachment 285738 [details]
Patch
Comment 3 Timothy Hatcher 2016-08-10 11:53:27 PDT
Comment on attachment 285738 [details]
Patch

Timelines will soon be able to be reordered, so the Allocations timeline will not always be the last one. Other Timeline record bars should be clickable in the future too. See bug 147236 for an older bug about this.

How does this affect the selection boxes? Are the dimmed areas behind or above the S icons?

We could land this as a workaround until bug 147236 is fixed. We should add a FIXME comment in that case.
Comment 4 Nikita Vasilyev 2016-08-10 11:54:31 PDT
Created attachment 285739 [details]
[Animated GIF] With patch applied
Comment 5 Nikita Vasilyev 2016-08-10 12:07:29 PDT
Created attachment 285741 [details]
Patch
Comment 6 WebKit Commit Bot 2016-08-10 12:37:08 PDT
Comment on attachment 285741 [details]
Patch

Clearing flags on attachment: 285741

Committed r204339: <http://trac.webkit.org/changeset/204339>
Comment 7 WebKit Commit Bot 2016-08-10 12:37:12 PDT
All reviewed patches have been landed.  Closing bug.