Bug 16074

Summary: execCommand("InsertHorizontalRule", false, "") results in id="" being inserted
Product: WebKit Reporter: Mark Rowe (bdash) <mrowe>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Severity: Trivial    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.4   
URL: http://bdash.net.nz/files/arguments-combinations.html
Description Flags
Patch sam: review+

Description Mark Rowe (bdash) 2007-11-20 12:35:55 PST
http://bdash.net.nz/files/arguments-combinations.html is a test case using InsertOrderedList rather than InsertHorizontalRule.  You'll notice that a test is failing as InsertOrderedList does not insert id="" when the empty string is passed as the value argument.  According to the HTML 5 specification an empty id attribute is not valid.  I believe that InsertHorizontalRule should match InsertOrderedList/InsertUnorderedList on this point.
Comment 1 Mark Rowe (bdash) 2007-11-20 12:41:03 PST
Created attachment 17419 [details]
Comment 2 Sam Weinig 2007-11-20 13:20:33 PST
Comment on attachment 17419 [details]

I think a test of InsertOrderedList and InsertUnorderedList with an empty string 3rd parameter would be nice if it doesn't already exist. 

Comment 3 Mark Rowe (bdash) 2007-11-20 13:36:45 PST
Landed in r27931.