Bug 160718

Summary: Support MediaTrackConstraintSet and MediaTrackConstraints IDL definition
Product: WebKit Reporter: George Ruan <gruan>
Component: MediaAssignee: George Ruan <gruan>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: cdumez, eric.carlson, jonlee, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 160798    
Attachments:
Description Flags
Patch none

Attachments
Patch (39.15 KB, patch)
2016-08-09 17:26 PDT, George Ruan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-08-09 16:39:17 PDT
<rdar://problem/27776658>
George Ruan
Comment 2 2016-08-09 17:26:30 PDT
Created attachment 285697 [details] Patch
Chris Dumez
Comment 3 2016-08-09 19:29:39 PDT
Comment on attachment 285697 [details] Patch Given how complex these dictionaries are and the way they are used, I feel it may be simpler for now to not bother with dictionaries at all in the IDL. We could just mark getConstaints() and applyConstraints() as [Custom] in the IDL (not declare any dictionaries in the IDL) and convert and do the JSValue <-> Internal Class conversion in the custom bindings. This way, you can declare your internal MediaTrackContraints class whatever way you like and make it convenient to use on native side. I think it is going to be a while until we can support such complex dictionaries in the bindings generator and the current struct it is able to generate is not very useful to us on native side and is very inconvenient to use.
George Ruan
Comment 4 2016-08-10 09:08:26 PDT
OK, it does seem like the dictionary MediaTrackConstraintSet and MediaTrackConstraints will not help us all that much in parsing the data. Doing it in Custom works.
Note You need to log in before you can comment on or make changes to this bug.