Bug 160715

Summary: Instantiate WebKit plug-ins at layout time, instead of at style resolution time
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, gyuyoung.kim, japhet
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Anders Carlsson
Reported 2016-08-09 16:05:11 PDT
Instantiate WebKit plug-ins at layout time, instead of at style resolution time
Attachments
Patch (22.94 KB, patch)
2016-08-09 16:07 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Patch (23.06 KB, patch)
2016-08-09 16:18 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2016-08-09 16:07:46 PDT
Created attachment 285684 [details] Patch
Anders Carlsson
Comment 2 2016-08-09 16:18:26 PDT
Created attachment 285686 [details] Patch
Tim Horton
Comment 3 2016-08-09 17:36:35 PDT
Comment on attachment 285686 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285686&action=review > Source/WebCore/html/HTMLEmbedElement.h:48 > + void updateWidget(CreatePlugins) final; You're changing the capitalization above but not here? :) > Source/WebKit/win/WebCoreSupport/WebFrameLoaderClient.cpp:1073 > + return ObjectContentType::Frame; // Go ahead and hope that we can display the content. Maybe remove the silly comment?
WebKit Commit Bot
Comment 4 2016-08-09 18:32:45 PDT
Comment on attachment 285686 [details] Patch Clearing flags on attachment: 285686 Committed r204320: <http://trac.webkit.org/changeset/204320>
WebKit Commit Bot
Comment 5 2016-08-09 18:32:49 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.