Bug 160710

Summary: Calling splitText() on a parent-less Text node should update associated ranges
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, kangil.han, rniwa, ryanhaddad
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Chris Dumez 2016-08-09 14:48:59 PDT
Calling splitText() on a parent-less Text node should update associated ranges:
- https://dom.spec.whatwg.org/#concept-text-split (Step 9)

We currently only update ranges for Text nodes that have a parent.
Comment 1 Chris Dumez 2016-08-09 14:54:18 PDT
Created attachment 285679 [details]
Patch
Comment 2 WebKit Commit Bot 2016-08-09 15:32:14 PDT
Comment on attachment 285679 [details]
Patch

Clearing flags on attachment: 285679

Committed r204311: <http://trac.webkit.org/changeset/204311>
Comment 3 WebKit Commit Bot 2016-08-09 15:32:19 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Ryan Haddad 2016-08-09 17:37:01 PDT
This changed caused fast/dom/non-numeric-values-numeric-parameters.html to crash due to failing: ASSERT(oldNode->nextSibling())

https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r204312%20(7299)/results.html
Comment 5 Chris Dumez 2016-08-09 18:11:56 PDT
(In reply to comment #4)
> This changed caused fast/dom/non-numeric-values-numeric-parameters.html to
> crash due to failing: ASSERT(oldNode->nextSibling())
> 
> https://build.webkit.org/results/
> Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r204312%20(7299)/results.html

Looking, thanks.
Comment 6 Chris Dumez 2016-08-09 18:18:45 PDT
(In reply to comment #5)
> (In reply to comment #4)
> > This changed caused fast/dom/non-numeric-values-numeric-parameters.html to
> > crash due to failing: ASSERT(oldNode->nextSibling())
> > 
> > https://build.webkit.org/results/
> > Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r204312%20(7299)/results.html
> 
> Looking, thanks.

Should be fixed in <http://trac.webkit.org/changeset/204319>.