Bug 160700

Summary: Implement "dumb" WK2 support for gamepads
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit2Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 134076, 134675    
Attachments:
Description Flags
Patch
none
Patch none

Description Brady Eidson 2016-08-09 11:20:08 PDT 
Implement "dumb" WK2 support for gamepads

The support is "dumb" because:
- It uses a timer to refresh gamepad values instead of syncing to the display as spec'ed
- It sends gamepad updates to all tabs instead of just the focused tab

Those are tracked by https://bugs.webkit.org/show_bug.cgi?id=160673 and https://bugs.webkit.org/show_bug.cgi?id=160699, respectively.
Comment 1 Brady Eidson 2016-08-09 11:32:00 PDT 
Created attachment 285652 [details]
Patch
Comment 2 Brady Eidson 2016-08-09 12:05:05 PDT 
Created attachment 285658 [details]
Patch
Comment 3 Alex Christensen 2016-08-09 12:10:15 PDT 
Comment on attachment 285658 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285658&action=review

r=me.  Verified functionality manually.  We really need some tests.

> Source/WebKit2/Shared/Gamepad/GamepadData.h:50
> +    String loggingString() const;

#if !LOG_DISABLED around this?
Comment 4 WebKit Commit Bot 2016-08-09 14:30:33 PDT 
Comment on attachment 285658 [details]
Patch

Clearing flags on attachment: 285658

Committed r204297: <http://trac.webkit.org/changeset/204297>
Comment 5 WebKit Commit Bot 2016-08-09 14:30:37 PDT 
All reviewed patches have been landed.  Closing bug.