Bug 160694

Summary: Move plug-in enumeration from WebPlatformStrategies to WebPluginInfoProvider
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mitz: review+

Description Anders Carlsson 2016-08-09 09:35:39 PDT
Move Plug-in enumeration from WebPlatformStrategies to WebPluginInfoProvider
Comment 1 Anders Carlsson 2016-08-09 09:36:45 PDT
Created attachment 285643 [details]
Patch
Comment 2 mitz 2016-08-09 09:57:26 PDT
Comment on attachment 285643 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285643&action=review

> Source/WebKit/mac/WebCoreSupport/WebPluginInfoProvider.mm:65
> +    NSArray* pluginsArray = [[WebPluginDatabase sharedDatabase] plugins];

Star on the wrong side of the space. Use .plugins.

> Source/WebKit/mac/WebCoreSupport/WebPluginInfoProvider.mm:66
> +    for (unsigned i = 0; i < [pluginsArray count]; ++i) {

Use fast enumeration.

> Source/WebKit/mac/WebCoreSupport/WebPluginInfoProvider.mm:69
> +        plugins.append([plugin pluginInfo]);

Use .pluginInfo.
Comment 3 Anders Carlsson 2016-08-09 09:59:09 PDT
Committed r204282: <http://trac.webkit.org/changeset/204282>