|Summary:||webkit-gtk tarball fails to build due to missing files|
|Product:||WebKit||Reporter:||Jeremy Huddleston Sequoia <jeremyhu>|
|Component:||WebKitGTK||Assignee:||Konstantin Tokarev <annulen>|
|Severity:||Normal||CC:||annulen, bugs-noreply, cgarcia, commit-queue, jeremyhu, mcatanzaro|
|Version:||WebKit Nightly Build|
Description Jeremy Huddleston Sequoia 2016-08-08 23:52:41 PDT
As mentioned on the mailing list, I decided to make the jump from git to tarballs to test out the 2.13.x series. Unfortunately, it looks like tarball creation is dropping files on the floor. CMake Error at Source/cmake/WebKitMacros.cmake:249 (add_library): Cannot find source file: spi/darwin/CommonCryptoSPI.h Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp .hxx .in .txx Call Stack (most recent call first): Source/WTF/wtf/CMakeLists.txt:305 (WEBKIT_FRAMEWORK) CMake Error: Cannot determine link language for target "WTF". CMake Error: CMake can not determine linker language for target: WTF I notice you're missing (at least) these paths: Source/WebCore/platform/spi Source/WebKit2/Platform/spi Source/WTF/wtf/spi I didn't do a deep comparison. I just looked for spi in the tarball and in the repository and came up with those hits. Carlos responded with: This is a regression introduced in r203620, see bug #160094. I guess Konstantin assumed that those spi files are only used by mac builds, but I guess they are also needed to build gtk on mac.
Comment 1 Konstantin Tokarev 2016-08-08 23:58:54 PDT
My bad, indeed CommonCryptoSPI.h is needed e.g. for OSRandomSource.cpp
Comment 3 WebKit Commit Bot 2016-08-09 09:59:17 PDT
Comment on attachment 285632 [details] Patch Clearing flags on attachment: 285632 Committed r204283: <http://trac.webkit.org/changeset/204283>
Comment 4 WebKit Commit Bot 2016-08-09 09:59:21 PDT
All reviewed patches have been landed. Closing bug.