Bug 160670

Summary:

Add a new PluginInfoProvider class, to replace PluginStrategy

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, hs85.jeong

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

160775

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Anders Carlsson

Reported 2016-08-08 15:36:32 PDT

Add a new PluginInfoProvider class, to replace PluginStrategy

Attachments
Patch (56.68 KB, patch) 2016-08-08 15:40 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (56.72 KB, patch) 2016-08-08 15:48 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (57.73 KB, patch) 2016-08-08 16:03 PDT, Anders Carlsson	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Anders Carlsson

Comment 1 2016-08-08 15:40:40 PDT

Created attachment 285593 [details] Patch

WebKit Commit Bot

Comment 2 2016-08-08 15:43:00 PDT

Attachment 285593 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebCoreSupport/WebPluginInfoProvider.mm:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/win/WebCoreSupport/WebPluginInfoProvider.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/win/WebCoreSupport/WebPluginInfoProvider.cpp:30: Bad include order. Mixing system and custom headers. [build/include_order] [4] Total errors found: 3 in 29 files If any of these errors are false positives, please file a bug against check-webkit-style.

Sam Weinig

Comment 3 2016-08-08 15:45:48 PDT

Comment on attachment 285593 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285593&action=review > Source/WebKit/win/WebCoreSupport/WebPluginInfoProvider.h:26 > +#import <WebCore/PluginInfoProvider.h> Missing #pragma once. > Source/WebKit2/WebProcess/Plugins/WebPluginInfoProvider.h:26 > +#include <WebCore/PluginInfoProvider.h> Missing #pragma once

Anders Carlsson

Comment 4 2016-08-08 15:48:00 PDT

Created attachment 285594 [details] Patch

WebKit Commit Bot

Comment 5 2016-08-08 15:49:47 PDT

Attachment 285594 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebCoreSupport/WebPluginInfoProvider.mm:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/win/WebCoreSupport/WebPluginInfoProvider.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/win/WebCoreSupport/WebPluginInfoProvider.cpp:30: Bad include order. Mixing system and custom headers. [build/include_order] [4] Total errors found: 3 in 29 files If any of these errors are false positives, please file a bug against check-webkit-style.

Anders Carlsson

Comment 6 2016-08-08 16:03:40 PDT

Created attachment 285596 [details] Patch

WebKit Commit Bot

Comment 7 2016-08-08 16:04:51 PDT

Attachment 285596 [details] did not pass style-queue: ERROR: Source/WebKit/mac/WebCoreSupport/WebPluginInfoProvider.mm:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WebKit/win/WebCoreSupport/WebPluginInfoProvider.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 2 in 31 files If any of these errors are false positives, please file a bug against check-webkit-style.

Anders Carlsson

Comment 8 2016-08-08 16:45:19 PDT

Committed r204268: <http://trac.webkit.org/changeset/204268>

Hunseop Jeong

Comment 9 2016-08-16 20:48:38 PDT

CMake build fix Committed r204548: <http://trac.webkit.org/changeset/204548>

Note You need to log in before you can comment on or make changes to this bug.