Bug 160663

Summary: Align Selection API with the specification
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: HTML EditingAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, darin, dbates, dmazzoni, enrica, esprehn+autocc, jcraig, jdiggs, kangil.han, kondapallykalyan, mario, rniwa, samuel_white, sam
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://www.w3.org/TR/selection-api/#idl-def-Selection
Bug Depends on:    
Bug Blocks: 160667    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2016-08-08 10:49:00 PDT
Align Selection API with the specification: - https://www.w3.org/TR/selection-api/#idl-def-Selection In particular, the following changes need to be made: - Mark parameters as non-nullable when they should be. - Mark parameters as mandatory when they should be. - Use "unsigned long" type for offsets instead of "long".
Attachments
Patch (47.31 KB, patch)
2016-08-08 10:55 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (47.91 KB, patch)
2016-08-08 11:05 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (47.09 KB, patch)
2016-08-08 13:02 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-08-08 10:55:17 PDT
Created attachment 285572 [details] Patch
Chris Dumez
Comment 2 2016-08-08 11:05:20 PDT
Created attachment 285573 [details] Patch
Ryosuke Niwa
Comment 3 2016-08-08 13:00:52 PDT
Comment on attachment 285573 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285573&action=review > Source/WebCore/page/DOMSelection.idl:63 > + void setBaseAndExtent(Node baseNode, unsigned long baseOffset, Node extentNode, unsigned long extentOffset); I think we should preserve the old behavior of clearing selection when baseNode/extentNode is null. Filed https://github.com/w3c/selection-api/issues/72.
Chris Dumez
Comment 4 2016-08-08 13:02:45 PDT
Created attachment 285579 [details] Patch
Chris Dumez
Comment 5 2016-08-08 13:31:56 PDT
Comment on attachment 285579 [details] Patch Clearing flags on attachment: 285579 Committed r204263: <http://trac.webkit.org/changeset/204263>
Chris Dumez
Comment 6 2016-08-08 13:32:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.