Summary: | Align Selection API with the specification | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
Component: | HTML Editing | Assignee: | Chris Dumez <cdumez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, commit-queue, darin, dbates, dmazzoni, enrica, esprehn+autocc, jcraig, jdiggs, kangil.han, kondapallykalyan, mario, rniwa, samuel_white, sam | ||||||||
Priority: | P2 | Keywords: | WebExposed | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
URL: | https://www.w3.org/TR/selection-api/#idl-def-Selection | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 160667 | ||||||||||
Attachments: |
|
Description
Chris Dumez
2016-08-08 10:49:00 PDT
Created attachment 285572 [details]
Patch
Created attachment 285573 [details]
Patch
Comment on attachment 285573 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285573&action=review > Source/WebCore/page/DOMSelection.idl:63 > + void setBaseAndExtent(Node baseNode, unsigned long baseOffset, Node extentNode, unsigned long extentOffset); I think we should preserve the old behavior of clearing selection when baseNode/extentNode is null. Filed https://github.com/w3c/selection-api/issues/72. Created attachment 285579 [details]
Patch
Comment on attachment 285579 [details] Patch Clearing flags on attachment: 285579 Committed r204263: <http://trac.webkit.org/changeset/204263> All reviewed patches have been landed. Closing bug. |