Bug 160635

Summary: Web Inspector: clean up prefixing of Automation protocol generated files
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Blaze Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, joepeck, keith_miller, mark.lam, mattbaker, msaboff, nvasilyev, saam, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed Fix timothy: review+, bburg: commit-queue-

Blaze Burg
Reported 2016-08-06 14:55:17 PDT
<yay>
Attachments
Proposed Fix (28.12 KB, patch)
2016-08-06 21:37 PDT, Blaze Burg 		timothy: review+
bburg: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-08-06 14:55:30 PDT
<rdar://problem/27735327>
Blaze Burg
Comment 2 2016-08-06 21:37:01 PDT
Created attachment 285520 [details] Proposed Fix
Blaze Burg
Comment 3 2016-08-06 21:37:25 PDT
Comment on attachment 285520 [details] Proposed Fix Needs to be landed with internal changes, do not cq+.
WebKit Commit Bot
Comment 4 2016-08-06 21:38:16 PDT
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
WebKit Commit Bot
Comment 5 2016-08-06 21:38:23 PDT
Attachment 285520 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/inspector/scripts/codegen/objc_generator.py:97: [ObjCGenerator.protocol_name] Instance of 'ObjCGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/cpp_generator.py:51: [CppGenerator.protocol_name] Instance of 'CppGenerator' has no 'model' member [pylint/E1101] [5] Total errors found: 2 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Blaze Burg
Comment 6 2016-08-08 09:45:09 PDT
Committed r204255: <http://trac.webkit.org/changeset/204255>
Note You need to log in before you can comment on or make changes to this bug.