Bug 160632

Summary: EWS Style Queue fails to process patches which fails validation
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, dbates, glenn, lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=159903
Attachments:
Description Flags
Proposed patch, also added a unittest. none

Aakash Jain
Reported 2016-08-06 11:32:00 PDT
Currently EWS Style Queue has 19 pending patches. Looking at the logs on the machine, there is an exception while processing any patch which fails validation. It is because of the change done is https://bugs.webkit.org/show_bug.cgi?id=159903 in PatchIsNotValid class.
Attachments
Proposed patch, also added a unittest. (3.07 KB, patch)
2016-08-06 11:39 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2016-08-06 11:39:37 PDT
Created attachment 285491 [details] Proposed patch, also added a unittest.
WebKit Commit Bot
Comment 2 2016-08-06 12:34:35 PDT
Comment on attachment 285491 [details] Proposed patch, also added a unittest. Clearing flags on attachment: 285491 Committed r204230: <http://trac.webkit.org/changeset/204230>
WebKit Commit Bot
Comment 3 2016-08-06 12:34:42 PDT
All reviewed patches have been landed. Closing bug.
Aakash Jain
Comment 4 2016-08-06 22:20:47 PDT
Style queue processed all the pending patches after the fix.
Note You need to log in before you can comment on or make changes to this bug.