Bug 160632

Summary: EWS Style Queue fails to process patches which fails validation
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Aakash Jain <aakash_jain>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, ap, commit-queue, dbates, glenn, lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=159903
Attachments:
Description Flags
Proposed patch, also added a unittest. none

Description Aakash Jain 2016-08-06 11:32:00 PDT 
Currently EWS Style Queue has 19 pending patches. Looking at the logs on the machine, there is an exception while processing any patch which fails validation. It is because of the change done is https://bugs.webkit.org/show_bug.cgi?id=159903 in PatchIsNotValid class.
Comment 1 Aakash Jain 2016-08-06 11:39:37 PDT 
Created attachment 285491 [details]
Proposed patch, also added a unittest.
Comment 2 WebKit Commit Bot 2016-08-06 12:34:35 PDT 
Comment on attachment 285491 [details]
Proposed patch, also added a unittest.

Clearing flags on attachment: 285491

Committed r204230: <http://trac.webkit.org/changeset/204230>
Comment 3 WebKit Commit Bot 2016-08-06 12:34:42 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Aakash Jain 2016-08-06 22:20:47 PDT 
Style queue processed all the pending patches after the fix.