Bug 160629

Summary:

Compile ICU breaking iterators at build time rather than run time

Product:

WebKit

Reporter:

Myles C. Maxfield <mmaxfield>

Component:

New Bugs

Assignee:

Myles C. Maxfield <mmaxfield>

Status:

RESOLVED CONFIGURATION CHANGED

Severity:

Normal

CC:

aakash_jain, andersca, ap, benjamin, buildbot, cdumez, cmarcelo, commit-queue, darin, dbates, jbedard, keith_miller, mark.lam, mitz, msaboff, rniwa, ryanhaddad, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

165940

Bug Blocks:

168207

Attachments:

Description	Flags
WIP	none
WIP	none
WIP	none
WIP	none
WIP	none
WIP	none
WIP	none
WIP	none
WIP	none
Archive of layout-test-results from ews103 for mac-yosemite	none
Archive of layout-test-results from ews107 for mac-yosemite-wk2	none
Archive of layout-test-results from ews114 for mac-yosemite	none
WIP	none
WIP	none
WIP	none
WIP	none
WIP	none
WIP	none
WIP	none
WIP	none
Patch	none
WIP	none
WIP	none
WIP	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
WIP	none
WIP	none
WIP	none
Patch	none
Patch	none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	mmaxfield: review-
Reduce filesystem access	none
Patch	none
Patch	none
Patch	none
Patch	none

Myles C. Maxfield

Reported 2016-08-05 21:49:20 PDT

Compile ICU breaking iterators at build time rather than run time

Attachments
WIP (52.83 KB, patch) 2016-08-05 21:52 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (226.80 KB, patch) 2016-08-05 23:52 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (263.62 KB, patch) 2016-08-06 01:02 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (263.71 KB, patch) 2016-08-06 01:12 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (263.75 KB, patch) 2016-08-06 01:51 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (282.82 KB, patch) 2016-08-06 11:11 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (264.85 KB, patch) 2016-08-06 12:18 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (268.73 KB, patch) 2016-08-06 15:14 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (268.84 KB, patch) 2016-08-06 15:39 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-yosemite (983.23 KB, application/zip) 2016-08-06 16:28 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (1.13 MB, application/zip) 2016-08-06 16:36 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews114 for mac-yosemite (1.38 MB, application/zip) 2016-08-06 16:49 PDT, Build Bot	no flags	Details
WIP (272.73 KB, patch) 2016-08-07 01:05 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (447.00 KB, patch) 2016-08-07 02:17 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (463.82 KB, patch) 2016-08-08 01:50 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (463.83 KB, patch) 2016-08-08 01:53 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (464.53 KB, patch) 2016-08-08 16:29 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (464.75 KB, patch) 2016-08-08 16:56 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (464.75 KB, patch) 2016-08-08 17:02 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (464.09 KB, patch) 2016-08-08 17:16 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (464.47 KB, patch) 2016-08-11 14:03 PDT, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (111.56 KB, patch) 2016-12-14 13:36 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (112.01 KB, patch) 2016-12-14 14:01 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (282.12 KB, patch) 2016-12-14 14:24 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (285.04 KB, patch) 2016-12-14 16:31 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (285.35 KB, patch) 2016-12-14 18:41 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (286.29 KB, patch) 2016-12-15 11:24 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (503.93 KB, patch) 2016-12-15 15:23 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (289.29 KB, patch) 2016-12-15 18:09 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (118.63 KB, patch) 2016-12-16 01:02 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (119.99 KB, patch) 2017-02-07 18:00 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
WIP (120.67 KB, patch) 2017-02-08 11:59 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (136.74 KB, patch) 2017-02-08 13:03 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (120.71 KB, patch) 2017-02-08 13:14 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (783.84 KB, application/zip) 2017-02-08 14:09 PST, Build Bot	no flags	Details
Patch (120.71 KB, patch) 2017-02-08 14:14 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (120.75 KB, patch) 2017-02-08 14:26 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (118.16 KB, patch) 2017-02-09 15:03 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (120.98 KB, patch) 2017-02-09 16:03 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (121.18 KB, patch) 2017-02-09 16:08 PST, Myles C. Maxfield	mmaxfield: review-	Details Formatted Diff Diff
Reduce filesystem access (126.94 KB, patch) 2017-02-10 18:08 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (56.81 KB, patch) 2017-02-13 11:54 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (57.11 KB, patch) 2017-02-13 17:34 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (57.15 KB, patch) 2017-02-13 17:37 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Patch (57.10 KB, patch) 2017-02-13 17:56 PST, Myles C. Maxfield	no flags	Details Formatted Diff Diff
Show Obsolete (44) View All Add attachment proposed patch, testcase, etc.

Myles C. Maxfield

Comment 1 2016-08-05 21:52:17 PDT

Created attachment 285480 [details] WIP

Myles C. Maxfield

Comment 2 2016-08-05 23:52:28 PDT

Created attachment 285484 [details] WIP

Myles C. Maxfield

Comment 3 2016-08-06 01:02:39 PDT

Created attachment 285485 [details] WIP

Myles C. Maxfield

Comment 4 2016-08-06 01:12:44 PDT

Created attachment 285486 [details] WIP

WebKit Commit Bot

Comment 5 2016-08-06 01:50:54 PDT

Attachment 285486 [details] did not pass style-queue: ERROR: Source/WTF/icu/unicode/uchriter.h:8: #ifndef header guard has wrong style, please use: uchriter_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/uchriter.h:11: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/uchriter.h:18: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:59: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:60: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:78: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:79: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:80: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:81: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:90: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:96: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:107: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:117: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:124: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:133: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:142: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:152: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:163: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:173: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:182: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:191: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:201: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:214: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:221: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:228: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:237: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:247: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:259: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:269: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:280: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:289: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:298: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:309: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:322: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/uchriter.h:322: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:335: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/uchriter.h:335: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:341: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:350: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:357: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:364: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:371: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:376: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:20: #ifndef header guard has wrong style, please use: brkiter_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:44: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:45: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:48: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:50: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:166: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:174: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:194: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:204: The parameter name "it" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:291: The parameter name "n" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:474: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:475: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:486: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:508: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:509: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:540: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:540: The parameter name "locale" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:556: The parameter name "key" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:572: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:581: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:611: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:612: The parameter name "loc" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:613: The parameter name "loc" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:614: The parameter name "loc" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:625: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:625: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:627: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:655: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WTF/icu/unicode/umisc.h:15: #ifndef header guard has wrong style, please use: umisc_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/umisc.h:37: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/umisc.h:42: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/umisc.h:47: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:29: #ifndef header guard has wrong style, please use: locid_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/locid.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:33: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:267: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:268: Extra space between const and char [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:268: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:269: Extra space between const and char [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:270: Extra space between const and char [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:285: Extra space before last semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] ERROR: Source/WTF/icu/unicode/locid.h:303: Extra space between UBool and operator [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:313: Extra space between UBool and operator [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:359: Extra space between UErrorCode& and success [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:359: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:388: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:388: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:397: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:397: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:404: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:404: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:411: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:411: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:494: Extra space between uint32_t and getLCID [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:522: Extra space between UnicodeString& and getDisplayLanguage [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:537: Extra space between UnicodeString& and getDisplayLanguage [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:537: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:538: Extra space between UnicodeString& and dispLang [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:538: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:549: Extra space between UnicodeString& and getDisplayScript [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:549: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:565: Extra space between UnicodeString& and getDisplayScript [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:565: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:566: Extra space between UnicodeString& and dispScript [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:566: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:577: Extra space between UnicodeString& and getDisplayCountry [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:577: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:593: Extra space between UnicodeString& and getDisplayCountry [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:593: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:594: Extra space between UnicodeString& and dispCountry [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:594: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:603: Extra space between UnicodeString& and getDisplayVariant [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:603: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:613: Extra space between UnicodeString& and getDisplayVariant [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:613: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:614: Extra space between UnicodeString& and dispVar [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:614: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:627: Extra space between UnicodeString& and getDisplayName [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:627: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:641: Extra space between UnicodeString& and ge tDisplayName [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:641: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:642: Extra space between UnicodeString& and name [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:642: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:648: Extra space between int32_t and hashCode [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:736: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/locid.h:808: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/rbbi.h:14: #ifndef header guard has wrong style, please use: rbbi_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:27: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/rbbi.h:39: Extra space between class and RuleBasedBreakIteratorTables [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:40: Extra space between class and BreakIterator [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:41: Extra space between class and RBBIDataWrapper [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:42: Extra space between class and UStack [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:43: Extra space between class and LanguageBreakEngine [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:44: Extra space between class and UnhandledEngine [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:72: Extra space between UText and *fText [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:79: Extra space between CharacterIterator and *fCharIter [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:99: Extra space between RBBIDataWrapper and *fData [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:104: Extra space between int32_t and fLastRuleStatusIndex [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:112: Extra space between UBool and fLastStatusIndexValid [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:119: Extra space between uint32_t and fDictionaryCharCount [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:128: Extra space between int32_t* and fCachedBreakPositions [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:134: Extra space between int32_t and fNumCachedBreakPositions [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:141: Extra space between int32_t and fPositionInCache [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:150: Extra space between UStack and *fLanguageBreakEngines [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:159: Extra space between UnhandledEngine and *fUnhandledBreakEngine [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:166: Extra space between int32_t and fBreakType [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:196: The parameter name "data" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:206: The parameter name "data" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:206: The parameter name "dontAdopt" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:240: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/rbbi.h:241: Extra space between UParseError and &parseError [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:241: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:241: The parameter name "parseError" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:242: Extra space between UErrorCode and &status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:242: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:268: Extra space between uint32_t and ruleLength [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:268: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:269: Extra space between UErrorCode and &status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:269: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:374: Extra space between virtual and CharacterIterator& [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:391: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:423: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:449: The parameter name "n" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:613: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:614: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:697: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:759: The parameter name "c" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:774: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/ucasemap.h:19: #ifndef header guard has wrong style, please use: ucasemap_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/ucasemap.h:22: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/ucasemap.h:23: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/ucasemap.h:269: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:270: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:271: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:300: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:301: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:302: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:329: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:330: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:331: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:381: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:419: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:420: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:421: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/chariter.h:10: #ifndef header guard has wrong style, please use: chariter_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/chariter.h:13: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/chariter.h:14: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/chariter.h:20: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/chariter.h:96: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/chariter.h:595: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/chariter.h:608: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/chariter.h:642: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/chariter.h:671: Extra space between int32_t and pos [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/chariter.h:677: Extra space between int32_t and begin [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/chariter.h:683: Extra space between int32_t and end [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/chariter.h:687: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:692: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:697: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:702: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:707: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:712: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:717: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/schriter.h:18: #ifndef header guard has wrong style, please use: schriter_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/schriter.h:21: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/schriter.h:29: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:52: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:63: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:64: Extra space between int32_t and textPos [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:64: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:82: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:83: Extra space between int32_t and textBegin [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:83: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:84: Extra space between int32_t and textEnd [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:84: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:85: Extra space between int32_t and textPos [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:85: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:95: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:101: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:111: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:112: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:122: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:131: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:138: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:147: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:154: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:161: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:168: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:176: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:182: Extra space between UnicodeString and text [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:182: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:17: #ifndef header guard has wrong style, please use: udata_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/udata.h:20: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/udata.h:39: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:173: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:200: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:252: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:252: The parameter name "isAcceptable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/udata.h:253: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:361: The parameter name "err" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/udata.h:392: The parameter name "err" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/udata.h:426: The parameter name "access" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/text/TextBreakIterator.h:43: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 249 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.

Myles C. Maxfield

Comment 6 2016-08-06 01:51:45 PDT

Created attachment 285487 [details] WIP

Alexey Proskuryakov

Comment 7 2016-08-06 08:19:04 PDT

Will be this result in problems whenever ICU compiled format changes? There are multiple scenarios in which ICU and WebKit are not interlocked. My recollection is that compilation is very fast.

Myles C. Maxfield

Comment 8 2016-08-06 10:35:31 PDT

(In reply to comment #7) > Will be this result in problems whenever ICU compiled format changes? There > are multiple scenarios in which ICU and WebKit are not interlocked. No, because the rules are compiled as a build step. The build step uses the system's ICU. (Just like how compiling C++ uses the system's compiler.)

Myles C. Maxfield

Comment 9 2016-08-06 11:11:51 PDT

Created attachment 285490 [details] WIP

Myles C. Maxfield

Comment 10 2016-08-06 12:18:04 PDT

Created attachment 285492 [details] WIP

Alexey Proskuryakov

Comment 11 2016-08-06 12:26:25 PDT

No, because the rules are compiled as a build step. The build step uses the system's ICU. > This is actually exactly what I expect to cause issues. Continuing the discussion in rdar://problem/7131057.

mitz

Comment 12 2016-08-06 12:34:54 PDT

Comment on attachment 285492 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=285492&action=review > Source/WTF/wtf/DerivedSources.make:25 > +# Copyright (C) 2016 Apple Inc. All rights reserved. > +# > +# Redistribution and use in source and binary forms, with or without > +# modification, are permitted provided that the following conditions > +# are met: > +# > +# 1. Redistributions of source code must retain the above copyright > +# notice, this list of conditions and the following disclaimer. > +# 2. Redistributions in binary form must reproduce the above copyright > +# notice, this list of conditions and the following disclaimer in the > +# documentation and/or other materials provided with the distribution. > +# 3. Neither the name of Apple Inc. ("Apple") nor the names of > +# its contributors may be used to endorse or promote products derived > +# from this software without specific prior written permission. > +# > +# THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY > +# EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED > +# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE > +# DISCLAIMED. IN NO EVENT SHALL APPLE OR ITS CONTRIBUTORS BE LIABLE FOR ANY > +# DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES > +# (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; > +# LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND > +# ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF > +# THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. This doesn’t appear to be the right license.

mitz

Comment 13 2016-08-06 12:38:05 PDT

Comment on attachment 285492 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=285492&action=review > Source/WTF/ChangeLog:10 > + * wtf/genbrk: Added. Adding prebuilt binaries to the source tree is incompatible with how Apple’s internal build system works.

Myles C. Maxfield

Comment 14 2016-08-06 15:14:06 PDT

Created attachment 285499 [details] WIP

WebKit Commit Bot

Comment 15 2016-08-06 15:17:00 PDT

Attachment 285499 [details] did not pass style-queue: ERROR: Source/WTF/icu/unicode/uchriter.h:8: #ifndef header guard has wrong style, please use: uchriter_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/uchriter.h:11: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/uchriter.h:18: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:59: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:60: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:78: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:79: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:80: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:81: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:90: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:96: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:107: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:117: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:124: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:133: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:142: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:152: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:163: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:173: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:182: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:191: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:201: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:214: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:221: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:228: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:237: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:247: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:259: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:269: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:280: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:289: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:298: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:309: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:322: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/uchriter.h:322: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:335: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/uchriter.h:335: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:341: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:350: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:357: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:364: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:371: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:376: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:20: #ifndef header guard has wrong style, please use: brkiter_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:44: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:45: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:48: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:50: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:166: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:174: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:194: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:204: The parameter name "it" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:291: The parameter name "n" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:474: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:475: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:486: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:508: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:509: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:540: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:540: The parameter name "locale" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:556: The parameter name "key" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:572: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:581: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:611: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:612: The parameter name "loc" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:613: The parameter name "loc" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:614: The parameter name "loc" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:625: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:625: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:627: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:655: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WTF/icu/unicode/umisc.h:15: #ifndef header guard has wrong style, please use: umisc_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/umisc.h:37: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/umisc.h:42: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/umisc.h:47: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:29: #ifndef header guard has wrong style, please use: locid_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/locid.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:33: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:267: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:268: Extra space between const and char [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:268: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:269: Extra space between const and char [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:270: Extra space between const and char [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:285: Extra space before last semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] ERROR: Source/WTF/icu/unicode/locid.h:303: Extra space between UBool and operator [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:313: Extra space between UBool and operator [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:359: Extra space between UErrorCode& and success [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:359: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:388: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:388: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:397: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:397: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:404: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:404: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:411: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:411: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:494: Extra space between uint32_t and getLCID [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:522: Extra space between UnicodeString& and getDisplayLanguage [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:537: Extra space between UnicodeString& and getDisplayLanguage [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:537: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:538: Extra space between UnicodeString& and dispLang [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:538: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:549: Extra space between UnicodeString& and getDisplayScript [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:549: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:565: Extra space between UnicodeString& and getDisplayScript [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:565: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:566: Extra space between UnicodeString& and dispScript [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:566: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:577: Extra space between UnicodeString& and getDisplayCountry [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:577: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:593: Extra space between UnicodeString& and getDisplayCountry [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:593: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:594: Extra space between UnicodeString& and dispCountry [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:594: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:603: Extra space between UnicodeString& and getDisplayVariant [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:603: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:613: Extra space between UnicodeString& and getDisplayVariant [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:613: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:614: Extra space between UnicodeString& and dispVar [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:614: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:627: Extra space between UnicodeString& and getDisplayName [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:627: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:641: Extra space between UnicodeString& and getDisplayName [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:641: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:642: Extra space between UnicodeString& and name [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:642: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:648: Extra space between int32_t and hashCode [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:736: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/locid.h:808: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/rbbi.h:14: #ifndef header guard has wrong style, please use: rbbi_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:27: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/rbbi.h:39: Extra space between class and RuleBasedBreakIteratorTables [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:40: Extra space between class and BreakIterator [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:41: Extra space between class and RBBIDataWrapper [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:42: Extra space between class and UStack [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:43: Extra space between class and LanguageBreakEngine [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:44: Extra space between class and UnhandledEngine [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:72: Extra space between UText and *fText [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:79: Extra space between CharacterIterator and *fCharIter [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:99: Extra space between RBBIDataWrapper and *fData [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:104: Extra space between int32_t and fLastRuleStatusIndex [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:112: Extra space between UBool and fLastStatusIndexValid [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:119: Extra space between uint32_t and fDictionaryCharCount [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:128: Extra space between int32_t* and fCachedBreakPositions [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:134: Extra space between int32_t and fNumCachedBreakPositions [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:141: Extra space between int32_t and fPositionInCache [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:150: Extra space between UStack and *fLanguageBreakEngines [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:159: Extra space between UnhandledEngine and *fUnhandledBreakEngine [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:166: Extra space between int32_t and fBreakType [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:196: The parameter name "data" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:206: The parameter name "data" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:206: The parameter name "dontAdopt" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:240: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/rbbi.h:241: Extra space between UParseError and &parseError [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:241: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:241: The parameter name "parseError" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:242: Extra space between UErrorCode and &status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:242: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:268: Extra space between uint32_t and ruleLength [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:268: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:269: Extra space between UErrorCode and &status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:269: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:374: Extra space between virtual and CharacterIterator& [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:391: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:423: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:449: The parameter name "n" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:613: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:614: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:697: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:759: The parameter name "c" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:774: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/ucasemap.h:19: #ifndef header guard has wrong style, please use: ucasemap_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/ucasemap.h:22: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/ucasemap.h:23: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/ucasemap.h:269: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:270: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:271: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:300: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:301: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:302: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:329: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:330: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:331: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:381: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:419: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:420: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:421: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/chariter.h:10: #ifndef header guard has wrong style, please use: chariter_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/chariter.h:13: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/chariter.h:14: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/chariter.h:20: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/chariter.h:96: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/chariter.h:595: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/chariter.h:608: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/chariter.h:642: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/chariter.h:671: Extra space between int32_t and pos [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/chariter.h:677: Extra space between int32_t and begin [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/chariter.h:683: Extra space between int32_t and end [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/chariter.h:687: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:692: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:697: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:702: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:707: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:712: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:717: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/schriter.h:18: #ifndef header guard has wrong style, please use: schriter_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/schriter.h:21: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/schriter.h:29: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:52: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:63: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:64: Extra space between int32_t and textPos [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:64: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:82: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:83: Extra space between int32_t and textBegin [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:83: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:84: Extra space between int32_t and textEnd [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:84: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:85: Extra space between int32_t and textPos [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:85: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:95: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:101: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:111: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:112: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:122: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:131: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:138: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:147: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:154: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:161: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:168: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:176: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:182: Extra space between UnicodeString and text [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:182: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/CMakeLists.txt:263: Alphabetical sorting problem. "wtf/text/BreakingRules/LineBreakIteratorUAX14LooseCJK.txt" should be before "wtf/text/BreakingRules/LineBreakIteratorUAX14NonCJK.txt". [list/order] [5] ERROR: Source/WTF/wtf/CMakeLists.txt:269: Alphabetical sorting problem. "wtf/text/BreakingRules/LineBreakIteratorEpilogue.txt" should be before "wtf/text/BreakingRules/LineBreakIteratorUAX14StrictNonCJK.txt". [list/order] [5] ERROR: Source/WTF/icu/unicode/udata.h:17: #ifndef header guard has wrong style, please use: udata_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/udata.h:20: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/udata.h:39: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:173: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:200: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:252: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:252: The parameter name "isAcceptable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/udata.h:253: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:361: The parameter name "err" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/udata.h:392: The parameter name "err" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/udata.h:426: The parameter name "access" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/text/TextBreakIterator.h:43: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 251 in 31 files If any of these errors are false positives, please file a bug against check-webkit-style.

Myles C. Maxfield

Comment 16 2016-08-06 15:18:55 PDT

<rdar://problem/7131057>

Myles C. Maxfield

Comment 17 2016-08-06 15:39:24 PDT

Created attachment 285503 [details] WIP

WebKit Commit Bot

Comment 18 2016-08-06 15:41:31 PDT

Attachment 285503 [details] did not pass style-queue: ERROR: Source/WTF/icu/unicode/uchriter.h:8: #ifndef header guard has wrong style, please use: uchriter_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/uchriter.h:11: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/uchriter.h:18: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:59: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:60: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:78: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:79: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:80: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:81: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:90: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:96: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:107: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:117: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:124: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:133: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:142: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:152: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:163: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:173: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:182: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:191: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:201: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:214: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:221: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:228: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:237: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:247: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:259: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:269: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:280: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:289: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:298: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:309: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:322: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/uchriter.h:322: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:335: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/uchriter.h:335: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:341: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:350: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:357: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:364: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:371: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:376: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:20: #ifndef header guard has wrong style, please use: brkiter_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:44: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:45: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:48: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:50: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:166: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:174: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:194: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:204: The parameter name "it" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:291: The parameter name "n" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:474: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:475: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:486: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:508: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:509: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:540: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:540: The parameter name "locale" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:556: The parameter name "key" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:572: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:581: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:611: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:612: The parameter name "loc" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:613: The parameter name "loc" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:614: The parameter name "loc" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:625: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:625: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:627: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:655: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WTF/icu/unicode/umisc.h:15: #ifndef header guard has wrong style, please use: umisc_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/umisc.h:37: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/umisc.h:42: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/umisc.h:47: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:29: #ifndef header guard has wrong style, please use: locid_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/locid.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:33: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:267: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:268: Extra space between const and char [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:268: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:269: Extra space between const and char [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:270: Extra space between const and char [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:285: Extra space before last semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] ERROR: Source/WTF/icu/unicode/locid.h:303: Extra space between UBool and operator [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:313: Extra space between UBool and operator [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:359: Extra space between UErrorCode& and success [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:359: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:388: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:388: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:397: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:397: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:404: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:404: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:411: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:411: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:494: Extra space between uint32_t and getLCID [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:522: Extra space between UnicodeString& and getDisplayLanguage [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:537: Extra space between UnicodeString& and getDisplayLanguage [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:537: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:538: Extra space between UnicodeString& and dispLang [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:538: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:549: Extra space between UnicodeString& and getDisplayScript [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:549: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:565: Extra space between UnicodeString& and getDisplayScript [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:565: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:566: Extra space between UnicodeString& and dispScript [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:566: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:577: Extra space between UnicodeString& and getDisplayCountry [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:577: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:593: Extra space between UnicodeString& and getDisplayCountry [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:593: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:594: Extra space between UnicodeString& and dispCountry [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:594: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:603: Extra space between UnicodeString& and getDisplayVariant [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:603: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:613: Extra space between UnicodeString& and getDisplayVariant [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:613: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:614: Extra space between UnicodeString& and dispVar [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:614: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:627: Extra space between UnicodeString& and getDisplayName [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:627: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:641: Extra space between UnicodeString& and getDisplayName [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:641: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:642: Extra space between UnicodeString& and name [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:642: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:648: Extra space between int32_t and hashCode [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:736: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/locid.h:808: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/rbbi.h:14: #ifndef header guard has wrong style, please use: rbbi_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:27: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/rbbi.h:39: Extra space between class and RuleBasedBreakIteratorTables [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:40: Extra space between class and BreakIterator [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:41: Extra space between class and RBBIDataWrapper [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:42: Extra space between class and UStack [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:43: Extra space between class and LanguageBreakEngine [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:44: Extra space between class and UnhandledEngine [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:72: Extra space between UText and *fText [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:79: Extra space between CharacterIterator and *fCharIter [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:99: Extra space between RBBIDataWrapper and *fData [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:104: Extra space between int32_t and fLastRuleStatusIndex [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:112: Extra space between UBool and fLastStatusIndexValid [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:119: Extra space between uint32_t and fDictionaryCharCount [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:128: Extra space between int32_t* and fCachedBreakPositions [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:134: Extra space between int32_t and fNumCachedBreakPositions [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:141: Extra space between int32_t and fPositionInCache [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:150: Extra space between UStack and *fLanguageBreakEngines [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:159: Extra space between UnhandledEngine and *fUnhandledBreakEngine [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:166: Extra space between int32_t and fBreakType [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:196: The parameter name "data" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:206: The parameter name "data" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:206: The parameter name "dontAdopt" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:240: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/rbbi.h:241: Extra space between UParseError and &parseError [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:241: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:241: The parameter name "parseError" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:242: Extra space between UErrorCode and &status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:242: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:268: Extra space between uint32_t and ruleLength [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:268: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:269: Extra space between UErrorCode and &status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:269: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:374: Extra space between virtual and CharacterIterator& [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:391: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:423: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:449: The parameter name "n" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:613: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:614: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:697: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:759: The parameter name "c" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:774: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/ucasemap.h:19: #ifndef header guard has wrong style, please use: ucasemap_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/ucasemap.h:22: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/ucasemap.h:23: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/ucasemap.h:269: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:270: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:271: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:300: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:301: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:302: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:329: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:330: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:331: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:381: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:419: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:420: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:421: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/chariter.h:10: #ifndef header guard has wrong style, please use: chariter_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/chariter.h:13: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/chariter.h:14: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/chariter.h:20: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/chariter.h:96: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/chariter.h:595: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/chariter.h:608: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/chariter.h:642: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/chariter.h:671: Extra space between int32_t and pos [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/chariter.h:677: Extra space between int32_t and begin [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/chariter.h:683: Extra space between int32_t and end [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/chariter.h:687: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:692: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:697: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:702: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:707: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:712: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:717: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/schriter.h:18: #ifndef header guard has wrong style, please use: schriter_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/schriter.h:21: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/schriter.h:29: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:52: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:63: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:64: Extra space between int32_t and textPos [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:64: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:82: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:83: Extra space between int32_t and textBegin [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:83: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:84: Extra space between int32_t and textEnd [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:84: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:85: Extra space between int32_t and textPos [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:85: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:95: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:101: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:111: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:112: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:122: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:131: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:138: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:147: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:154: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:161: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:168: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:176: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:182: Extra space between UnicodeString and text [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:182: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/CMakeLists.txt:263: Alphabetical sorting problem. "text/BreakingRules/LineBreakIteratorUAX14LooseCJK.txt" should be before "text/BreakingRules/LineBreakIteratorUAX14NonCJK.txt". [list/order] [5] ERROR: Source/WTF/wtf/CMakeLists.txt:269: Alphabetical sorting problem. "text/BreakingRules/LineBreakIteratorEpilogue.txt" should be before "text/BreakingRules/LineBreakIteratorUAX14StrictNonCJK.txt". [list/order] [5] ERROR: Source/WTF/icu/unicode/udata.h:17: #ifndef header guard has wrong style, please use: udata_h [build/header_guard] [5] ERROR: Source/WTF/icu/unicode/udata.h:20: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/udata.h:39: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:173: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:200: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:252: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:252: The parameter name "isAcceptable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/udata.h:253: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:361: The parameter name "err" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/udata.h:392: The parameter name "err" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/udata.h:426: The parameter n ame "access" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/text/TextBreakIterator.h:43: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 251 in 31 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 19 2016-08-06 16:28:04 PDT

Comment on attachment 285503 [details] WIP Attachment 285503 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1825839 New failing tests: editing/selection/move-by-word-visually-multi-space.html editing/selection/move-by-word-visually-multi-line.html editing/selection/move-left-right.html editing/selection/move-by-character-brute-force.html editing/selection/move-by-word-visually-mac.html editing/selection/move-by-word-visually-single-space-one-element.html

Build Bot

Comment 20 2016-08-06 16:28:09 PDT

Created attachment 285507 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5

Build Bot

Comment 21 2016-08-06 16:36:50 PDT

Comment on attachment 285503 [details] WIP Attachment 285503 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1825851 New failing tests: editing/selection/move-by-word-visually-multi-space.html editing/selection/move-by-word-visually-multi-line.html editing/selection/move-by-character-brute-force.html editing/selection/move-by-word-visually-single-space-inline-element.html editing/selection/move-by-word-visually-mac.html editing/selection/move-by-word-visually-single-space-one-element.html editing/selection/caret-at-bidi-boundary.html

Build Bot

Comment 22 2016-08-06 16:36:55 PDT

Created attachment 285508 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5

Build Bot

Comment 23 2016-08-06 16:49:53 PDT

Comment on attachment 285503 [details] WIP Attachment 285503 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1825880 New failing tests: editing/selection/move-by-word-visually-multi-space.html editing/selection/move-by-word-visually-multi-line.html editing/selection/move-left-right.html editing/selection/move-by-character-brute-force.html editing/selection/move-by-word-visually-mac.html editing/selection/move-by-word-visually-single-space-one-element.html

Build Bot

Comment 24 2016-08-06 16:49:58 PDT

Created attachment 285509 [details] Archive of layout-test-results from ews114 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-yosemite Platform: Mac OS X 10.10.5

Myles C. Maxfield

Comment 25 2016-08-07 01:05:06 PDT

Created attachment 285524 [details] WIP

Myles C. Maxfield

Comment 26 2016-08-07 02:17:14 PDT

Created attachment 285525 [details] WIP

mitz

Comment 27 2016-08-07 21:05:47 PDT

Comment on attachment 285525 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=285525&action=review > Source/WTF/WTF.xcodeproj/project.pbxproj:1638 > + 1CD187881D55698800CC7DEC /* PBXTargetDependency */, > 65AFA28E1630B99E003D723C /* PBXTargetDependency */, Apple’s internal build system forces the use of the same SDK for a target and for its dependencies, so this setup is incompatible with how Apple builds WTF for iOS.

Myles C. Maxfield

Comment 28 2016-08-08 01:50:23 PDT

Created attachment 285560 [details] WIP

Myles C. Maxfield

Comment 29 2016-08-08 01:53:04 PDT

Created attachment 285561 [details] WIP

Myles C. Maxfield

Comment 30 2016-08-08 16:29:03 PDT

Created attachment 285604 [details] WIP

Myles C. Maxfield

Comment 31 2016-08-08 16:56:47 PDT

Created attachment 285607 [details] WIP

Myles C. Maxfield

Comment 32 2016-08-08 17:02:26 PDT

Created attachment 285609 [details] WIP

Myles C. Maxfield

Comment 33 2016-08-08 17:16:17 PDT

Created attachment 285612 [details] WIP

Myles C. Maxfield

Comment 34 2016-08-11 14:03:35 PDT

Created attachment 285853 [details] Patch

Myles C. Maxfield

Comment 35 2016-12-14 13:36:04 PST

Created attachment 297121 [details] WIP

Myles C. Maxfield

Comment 36 2016-12-14 14:01:10 PST

Created attachment 297122 [details] WIP

WebKit Commit Bot

Comment 37 2016-12-14 14:05:06 PST

Attachment 297122 [details] did not pass style-queue: ERROR: Source/WTF/wtf/text/TextBreakIterator.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 1 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.

Myles C. Maxfield

Comment 38 2016-12-14 14:24:01 PST

Created attachment 297126 [details] WIP

WebKit Commit Bot

Comment 39 2016-12-14 14:26:59 PST

Attachment 297126 [details] did not pass style-queue: ERROR: Source/WTF/icu/unicode/uchriter.h:11: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/uchriter.h:18: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:59: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:60: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:78: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:79: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:80: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:81: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:90: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:96: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:107: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:117: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:124: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:133: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:142: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:152: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:163: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:173: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:182: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:191: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:201: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:214: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:221: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:228: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:237: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:247: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:259: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:269: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:280: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:289: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:298: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:309: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:322: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/uchriter.h:322: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:335: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/uchriter.h:335: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:341: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:350: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:357: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:364: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:371: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:376: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:44: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:45: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:48: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:50: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:166: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:174: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:194: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:204: The parameter name "it" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:291: The parameter name "n" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:474: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:475: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:486: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:508: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:509: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:540: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:540: The parameter name "locale" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:556: The parameter name "key" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:572: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:581: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:611: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:612: The parameter name "loc" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:613: The parameter name "loc" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:614: The parameter name "loc" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:625: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:625: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:627: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:655: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WTF/icu/unicode/umisc.h:37: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/umisc.h:42: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/umisc.h:47: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:33: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:267: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:268: Extra space between const and char [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:268: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:269: Extra space between const and char [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:270: Extra space between const and char [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:285: Extra space before last semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] ERROR: Source/WTF/icu/unicode/locid.h:303: Extra space between UBool and operator [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:313: Extra space between UBool and operator [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:359: Extra space between UErrorCode& and success [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:359: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:388: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:388: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:397: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:397: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:404: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:404: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:411: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:411: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:494: Extra space between uint32_t and getLCID [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:522: Extra space between UnicodeString& and getDisplayLanguage [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:537: Extra space between UnicodeString& and getDisplayLanguage [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:537: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:538: Extra space between UnicodeString& and dispLang [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:538: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:549: Extra space between UnicodeString& and getDisplayScript [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:549: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:565: Extra space between UnicodeString& and getDisplayScript [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:565: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:566: Extra space between UnicodeString& and dispScript [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:566: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:577: Extra space between UnicodeString& and getDisplayCountry [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:577: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:593: Extra space between UnicodeString& and getDisplayCountry [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:593: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:594: Extra space between UnicodeString& and dispCountry [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:594: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:603: Extra space between UnicodeString& and getDisplayVariant [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:603: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:613: Extra space between UnicodeString& and getDisplayVariant [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:613: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:614: Extra space between UnicodeString& and dispVar [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:614: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:627: Extra space between UnicodeString& and getDisplayName [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:627: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:641: Extra space between UnicodeString& and getDisplayName [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:641: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:642: Extra space between UnicodeString& and name [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:642: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:648: Extra space between int32_t and hashCode [whitespace/declaration] [3] ERROR: Source/WTF/icu/ unicode/locid.h:736: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/locid.h:808: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/rbbi.h:27: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/rbbi.h:39: Extra space between class and RuleBasedBreakIteratorTables [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:40: Extra space between class and BreakIterator [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:41: Extra space between class and RBBIDataWrapper [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:42: Extra space between class and UStack [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:43: Extra space between class and LanguageBreakEngine [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:44: Extra space between class and UnhandledEngine [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:72: Extra space between UText and *fText [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:79: Extra space between CharacterIterator and *fCharIter [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:99: Extra space between RBBIDataWrapper and *fData [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:104: Extra space between int32_t and fLastRuleStatusIndex [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:112: Extra space between UBool and fLastStatusIndexValid [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:119: Extra space between uint32_t and fDictionaryCharCount [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:128: Extra space between int32_t* and fCachedBreakPositions [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:134: Extra space between int32_t and fNumCachedBreakPositions [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:141: Extra space between int32_t and fPositionInCache [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:150: Extra space between UStack and *fLanguageBreakEngines [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:159: Extra space between UnhandledEngine and *fUnhandledBreakEngine [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:166: Extra space between int32_t and fBreakType [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:196: The parameter name "data" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:206: The parameter name "data" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:206: The parameter name "dontAdopt" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:240: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/rbbi.h:241: Extra space between UParseError and &parseError [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:241: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:241: The parameter name "parseError" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:242: Extra space between UErrorCode and &status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:242: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:268: Extra space between uint32_t and ruleLength [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:268: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:269: Extra space between UErrorCode and &status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:269: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:374: Extra space between virtual and CharacterIterator& [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:391: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:423: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:449: The parameter name "n" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:613: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:614: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:697: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:759: The parameter name "c" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:774: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/ucasemap.h:22: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/ucasemap.h:23: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/ucasemap.h:269: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:270: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:271: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:300: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:301: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:302: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:329: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:330: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:331: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:381: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:419: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:420: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:421: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/chariter.h:13: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/chariter.h:14: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/chariter.h:20: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/chariter.h:96: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/chariter.h:595: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/chariter.h:608: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/chariter.h:642: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/chariter.h:671: Extra space between int32_t and pos [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/chariter.h:677: Extra space between int32_t and begin [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/chariter.h:683: Extra space between int32_t and end [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/chariter.h:687: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:692: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:697: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:702: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:707: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:712: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:717: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/schriter.h:21: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/schriter.h:29: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:52: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:63: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:64: Extra space between int32_t and textPos [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:64: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:82: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:83: Extra space between int32_t and textBegin [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:83: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:84: Extra space between int32_t and textEnd [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:84: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:85: Extra space between int32_t and textPos [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:85: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:95: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:101: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:111: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:112: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:122: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:131: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:138: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:147: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:154: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:161: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:168: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:176: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:182: Extra space between UnicodeString and text [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:182: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:20: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/udata.h:39: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:173: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:200: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:252: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:252: The parameter name "isAcceptable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/udata.h:253: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:361: The parameter name "err" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/udata.h:392: The parameter name "err" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/udata.h:426: The parameter name "access" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/text/TextBreakIterator.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 240 in 32 files If any of these errors are false positives, please file a bug against check-webkit-style.

Myles C. Maxfield

Comment 40 2016-12-14 15:04:16 PST

Just verified that the compile rules work on Mac.

Myles C. Maxfield

Comment 41 2016-12-14 16:31:52 PST

Created attachment 297143 [details] Patch

WebKit Commit Bot

Comment 42 2016-12-14 16:33:42 PST

Attachment 297143 [details] did not pass style-queue: ERROR: Source/WTF/icu/unicode/uchriter.h:11: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/uchriter.h:18: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:59: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:60: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:78: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:79: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:80: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:81: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:90: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:96: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:107: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:117: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:124: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:133: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:142: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:152: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:163: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:173: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:182: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:191: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:201: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:214: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:221: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:228: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:237: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:247: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:259: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:269: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:280: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:289: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:298: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:309: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:322: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/uchriter.h:322: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:335: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/uchriter.h:335: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:341: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:350: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:357: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:364: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:371: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:376: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:44: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:45: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:48: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:50: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:166: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:174: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:194: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:204: The parameter name "it" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:291: The parameter name "n" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:474: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:475: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:486: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:508: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:509: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:540: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:540: The parameter name "locale" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:556: The parameter name "key" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:572: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:581: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:611: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:612: The parameter name "loc" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:613: The parameter name "loc" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:614: The parameter name "loc" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:625: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:625: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:627: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:655: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WTF/icu/unicode/umisc.h:37: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/umisc.h:42: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/umisc.h:47: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:33: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:267: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:268: Extra space between const and char [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:268: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:269: Extra space between const and char [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:270: Extra space between const and char [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:285: Extra space before last semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] ERROR: Source/WTF/icu/unicode/locid.h:303: Extra space between UBool and operator [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:313: Extra space between UBool and operator [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:359: Extra space between UErrorCode& and success [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:359: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:388: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:388: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:397: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:397: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:404: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:404: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:411: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:411: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:494: Extra space between uint32_t and getLCID [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:522: Extra space between UnicodeString& and getDisplayLanguage [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:537: Extra space between UnicodeString& and getDisplayLanguage [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:537: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:538: Extra space between UnicodeString& and dispLang [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:538: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:549: Extra space between UnicodeString& and getDisplayScript [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:549: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:565: Extra space between UnicodeString& and getDisplayScript [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:565: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:566: Extra space between UnicodeString& and dispScript [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:566: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:577: Extra space between UnicodeString& and getDisplayCountry [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:577: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:593: Extra space between UnicodeString& and getDisplayCountry [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:593: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:594: Extra space between UnicodeString& and dispCountry [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:594: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:603: Extra space between UnicodeString& and getDisplayVariant [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:603: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:613: Extra space between UnicodeString& and getDisplayVariant [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:613: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:614: Extra space between UnicodeString& and dispVar [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:614: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:627: Extra space between UnicodeString& and getDisplayName [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:627: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:641: Extra space between UnicodeString& and getDisplayName [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:641: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:642: Extra space between UnicodeString& and name [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:642: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:648: Extra space between int32_t and hashCode [whitespace/declaration] [3] ERROR: Source/WTF/icu/ unicode/locid.h:736: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/locid.h:808: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/rbbi.h:27: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/rbbi.h:39: Extra space between class and RuleBasedBreakIteratorTables [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:40: Extra space between class and BreakIterator [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:41: Extra space between class and RBBIDataWrapper [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:42: Extra space between class and UStack [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:43: Extra space between class and LanguageBreakEngine [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:44: Extra space between class and UnhandledEngine [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:72: Extra space between UText and *fText [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:79: Extra space between CharacterIterator and *fCharIter [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:99: Extra space between RBBIDataWrapper and *fData [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:104: Extra space between int32_t and fLastRuleStatusIndex [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:112: Extra space between UBool and fLastStatusIndexValid [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:119: Extra space between uint32_t and fDictionaryCharCount [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:128: Extra space between int32_t* and fCachedBreakPositions [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:134: Extra space between int32_t and fNumCachedBreakPositions [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:141: Extra space between int32_t and fPositionInCache [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:150: Extra space between UStack and *fLanguageBreakEngines [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:159: Extra space between UnhandledEngine and *fUnhandledBreakEngine [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:166: Extra space between int32_t and fBreakType [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:196: The parameter name "data" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:206: The parameter name "data" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:206: The parameter name "dontAdopt" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:240: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/rbbi.h:241: Extra space between UParseError and &parseError [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:241: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:241: The parameter name "parseError" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:242: Extra space between UErrorCode and &status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:242: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:268: Extra space between uint32_t and ruleLength [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:268: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:269: Extra space between UErrorCode and &status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:269: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:374: Extra space between virtual and CharacterIterator& [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:391: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:423: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:449: The parameter name "n" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:613: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:614: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:697: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:759: The parameter name "c" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:774: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/ucasemap.h:22: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/ucasemap.h:23: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/ucasemap.h:269: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:270: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:271: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:300: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:301: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:302: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:329: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:330: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:331: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:381: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:419: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:420: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:421: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/chariter.h:13: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/chariter.h:14: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/chariter.h:20: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/chariter.h:96: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/chariter.h:595: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/chariter.h:608: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/chariter.h:642: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/chariter.h:671: Extra space between int32_t and pos [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/chariter.h:677: Extra space between int32_t and begin [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/chariter.h:683: Extra space between int32_t and end [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/chariter.h:687: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:692: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:697: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:702: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:707: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:712: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:717: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/schriter.h:21: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/schriter.h:29: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:52: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:63: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:64: Extra space between int32_t and textPos [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:64: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:82: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:83: Extra space between int32_t and textBegin [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:83: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:84: Extra space between int32_t and textEnd [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:84: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:85: Extra space between int32_t and textPos [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:85: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:95: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:101: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:111: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:112: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:122: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:131: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:138: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:147: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:154: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:161: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:168: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:176: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:182: Extra space between UnicodeString and text [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:182: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:20: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/udata.h:39: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:173: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:200: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:252: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:252: The parameter name "isAcceptable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/udata.h:253: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:361: The parameter name "err" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/udata.h:392: The parameter name "err" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/udata.h:426: The parameter name "access" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/text/TextBreakIterator.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 240 in 32 files If any of these errors are false positives, please file a bug against check-webkit-style.

Myles C. Maxfield

Comment 43 2016-12-14 18:41:47 PST

Created attachment 297155 [details] Patch

WebKit Commit Bot

Comment 44 2016-12-14 18:43:38 PST

Attachment 297155 [details] did not pass style-queue: ERROR: Source/WTF/icu/unicode/uchriter.h:11: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/uchriter.h:18: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:59: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:60: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:78: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:79: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:80: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:81: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:90: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:96: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:107: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:117: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:124: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:133: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:142: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:152: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:163: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:173: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:182: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:191: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:201: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:214: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:221: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:228: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:237: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:247: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:259: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:269: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:280: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:289: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:298: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:309: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:322: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/uchriter.h:322: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:335: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/uchriter.h:335: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:341: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:350: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:357: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:364: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:371: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:376: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:44: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:45: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:48: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:50: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:166: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:174: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:194: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:204: The parameter name "it" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:291: The parameter name "n" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:474: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:475: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:486: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:508: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:509: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:540: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:540: The parameter name "locale" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:556: The parameter name "key" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:572: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:581: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:611: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:612: The parameter name "loc" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:613: The parameter name "loc" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:614: The parameter name "loc" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:625: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:625: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:627: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:655: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WTF/icu/unicode/umisc.h:37: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/umisc.h:42: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/umisc.h:47: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:33: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:267: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:268: Extra space between const and char [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:268: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:269: Extra space between const and char [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:270: Extra space between const and char [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:285: Extra space before last semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] ERROR: Source/WTF/icu/unicode/locid.h:303: Extra space between UBool and operator [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:313: Extra space between UBool and operator [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:359: Extra space between UErrorCode& and success [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:359: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:388: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:388: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:397: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:397: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:404: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:404: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:411: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:411: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:494: Extra space between uint32_t and getLCID [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:522: Extra space between UnicodeString& and getDisplayLanguage [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:537: Extra space between UnicodeString& and getDisplayLanguage [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:537: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:538: Extra space between UnicodeString& and dispLang [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:538: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:549: Extra space between UnicodeString& and getDisplayScript [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:549: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:565: Extra space between UnicodeString& and getDisplayScript [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:565: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:566: Extra space between UnicodeString& and dispScript [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:566: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:577: Extra space between UnicodeString& and getDisplayCountry [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:577: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:593: Extra space between UnicodeString& and getDisplayCountry [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:593: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:594: Extra space between UnicodeString& and dispCountry [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:594: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:603: Extra space between UnicodeString& and getDisplayVariant [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:603: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:613: Extra space between UnicodeString& and getDisplayVariant [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:613: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:614: Extra space between UnicodeString& and dispVar [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:614: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:627: Extra space between UnicodeString& and getDisplayName [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:627: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:641: Extra space between UnicodeString& and getDisplayName [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:641: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:642: Extra space between UnicodeString& and name [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:642: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:648: Extra space between int32_t and hashCode [whitespace/declaration] [3] ERROR: Source/WTF/icu/ unicode/locid.h:736: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/locid.h:808: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/rbbi.h:27: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/rbbi.h:39: Extra space between class and RuleBasedBreakIteratorTables [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:40: Extra space between class and BreakIterator [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:41: Extra space between class and RBBIDataWrapper [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:42: Extra space between class and UStack [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:43: Extra space between class and LanguageBreakEngine [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:44: Extra space between class and UnhandledEngine [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:72: Extra space between UText and *fText [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:79: Extra space between CharacterIterator and *fCharIter [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:99: Extra space between RBBIDataWrapper and *fData [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:104: Extra space between int32_t and fLastRuleStatusIndex [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:112: Extra space between UBool and fLastStatusIndexValid [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:119: Extra space between uint32_t and fDictionaryCharCount [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:128: Extra space between int32_t* and fCachedBreakPositions [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:134: Extra space between int32_t and fNumCachedBreakPositions [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:141: Extra space between int32_t and fPositionInCache [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:150: Extra space between UStack and *fLanguageBreakEngines [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:159: Extra space between UnhandledEngine and *fUnhandledBreakEngine [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:166: Extra space between int32_t and fBreakType [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:196: The parameter name "data" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:206: The parameter name "data" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:206: The parameter name "dontAdopt" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:240: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/rbbi.h:241: Extra space between UParseError and &parseError [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:241: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:241: The parameter name "parseError" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:242: Extra space between UErrorCode and &status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:242: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:268: Extra space between uint32_t and ruleLength [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:268: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:269: Extra space between UErrorCode and &status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:269: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:374: Extra space between virtual and CharacterIterator& [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:391: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:423: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:449: The parameter name "n" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:613: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:614: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:697: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:759: The parameter name "c" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:774: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/ucasemap.h:22: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/ucasemap.h:23: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/ucasemap.h:269: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:270: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:271: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:300: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:301: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:302: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:329: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:330: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:331: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:381: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:419: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:420: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:421: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/chariter.h:13: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/chariter.h:14: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/chariter.h:20: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/chariter.h:96: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/chariter.h:595: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/chariter.h:608: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/chariter.h:642: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/chariter.h:671: Extra space between int32_t and pos [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/chariter.h:677: Extra space between int32_t and begin [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/chariter.h:683: Extra space between int32_t and end [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/chariter.h:687: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:692: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:697: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:702: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:707: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:712: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:717: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/schriter.h:21: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/schriter.h:29: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:52: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:63: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:64: Extra space between int32_t and textPos [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:64: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:82: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:83: Extra space between int32_t and textBegin [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:83: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:84: Extra space between int32_t and textEnd [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:84: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:85: Extra space between int32_t and textPos [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:85: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:95: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:101: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:111: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:112: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:122: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:131: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:138: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:147: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:154: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:161: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:168: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:176: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:182: Extra space between UnicodeString and text [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:182: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:20: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/udata.h:39: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:173: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:200: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:252: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:252: The parameter name "isAcceptable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/udata.h:253: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:361: The parameter name "err" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/udata.h:392: The parameter name "err" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/udata.h:426: The parameter name "access" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/text/TextBreakIterator.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 240 in 32 files If any of these errors are false positives, please file a bug against check-webkit-style.

Myles C. Maxfield

Comment 45 2016-12-14 22:44:10 PST

(In reply to comment #40) > Just verified that the compile rules work on Mac. Just verified they work on iOS too.

mitz

Comment 46 2016-12-14 22:47:25 PST

Comment on attachment 297155 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297155&action=review > Source/WTF/wtf/text/BreakingRules/CursorMovementIteratorRules.txt:1 > +# Copyright (C) 2016 Apple Inc. All rights reserved. Seems like the contents of this and similar files come from TextBreakIterator.cpp and was authored before 2016.

Myles C. Maxfield

Comment 47 2016-12-15 11:24:07 PST

Created attachment 297205 [details] Patch

WebKit Commit Bot

Comment 48 2016-12-15 11:26:23 PST

Attachment 297205 [details] did not pass style-queue: ERROR: Source/WTF/icu/unicode/uchriter.h:11: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/uchriter.h:18: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:59: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:60: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:78: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:79: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:80: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:81: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:90: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:96: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:107: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:117: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:124: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:133: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:142: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:152: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:163: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:173: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:182: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:191: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:201: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:214: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:221: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:228: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:237: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:247: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:259: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:269: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:280: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:289: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:298: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:309: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:322: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/uchriter.h:322: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:335: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/uchriter.h:335: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:341: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:350: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:357: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:364: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:371: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:376: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:44: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:45: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:48: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:50: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:166: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:174: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:194: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:204: The parameter name "it" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:291: The parameter name "n" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:474: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:475: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:486: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:508: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:509: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:540: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:540: The parameter name "locale" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:556: The parameter name "key" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:572: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:581: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:611: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:612: The parameter name "loc" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:613: The parameter name "loc" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:614: The parameter name "loc" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:625: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:625: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:627: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:655: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WTF/icu/unicode/umisc.h:37: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/umisc.h:42: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/umisc.h:47: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:33: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:267: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:268: Extra space between const and char [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:268: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:269: Extra space between const and char [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:270: Extra space between const and char [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:285: Extra space before last semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] ERROR: Source/WTF/icu/unicode/locid.h:303: Extra space between UBool and operator [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:313: Extra space between UBool and operator [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:359: Extra space between UErrorCode& and success [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:359: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:388: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:388: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:397: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:397: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:404: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:404: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:411: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:411: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:494: Extra space between uint32_t and getLCID [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:522: Extra space between UnicodeString& and getDisplayLanguage [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:537: Extra space between UnicodeString& and getDisplayLanguage [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:537: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:538: Extra space between UnicodeString& and dispLang [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:538: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:549: Extra space between UnicodeString& and getDisplayScript [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:549: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:565: Extra space between UnicodeString& and getDisplayScript [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:565: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:566: Extra space between UnicodeString& and dispScript [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:566: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:577: Extra space between UnicodeString& and getDisplayCountry [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:577: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:593: Extra space between UnicodeString& and getDisplayCountry [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:593: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:594: Extra space between UnicodeString& and dispCountry [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:594: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:603: Extra space between UnicodeString& and getDisplayVariant [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:603: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:613: Extra space between UnicodeString& and getDisplayVariant [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:613: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:614: Extra space between UnicodeString& and dispVar [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:614: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:627: Extra space between UnicodeString& and getDisplayName [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:627: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:641: Extra space between UnicodeString& and getDisplayName [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:641: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:642: Extra space between UnicodeString& and name [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:642: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:648: Extra space between int32_t and hashCode [whitespace/declaration] [3] ERROR: Source/WTF/icu/ unicode/locid.h:736: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/locid.h:808: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/rbbi.h:27: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/rbbi.h:39: Extra space between class and RuleBasedBreakIteratorTables [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:40: Extra space between class and BreakIterator [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:41: Extra space between class and RBBIDataWrapper [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:42: Extra space between class and UStack [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:43: Extra space between class and LanguageBreakEngine [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:44: Extra space between class and UnhandledEngine [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:72: Extra space between UText and *fText [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:79: Extra space between CharacterIterator and *fCharIter [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:99: Extra space between RBBIDataWrapper and *fData [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:104: Extra space between int32_t and fLastRuleStatusIndex [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:112: Extra space between UBool and fLastStatusIndexValid [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:119: Extra space between uint32_t and fDictionaryCharCount [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:128: Extra space between int32_t* and fCachedBreakPositions [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:134: Extra space between int32_t and fNumCachedBreakPositions [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:141: Extra space between int32_t and fPositionInCache [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:150: Extra space between UStack and *fLanguageBreakEngines [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:159: Extra space between UnhandledEngine and *fUnhandledBreakEngine [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:166: Extra space between int32_t and fBreakType [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:196: The parameter name "data" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:206: The parameter name "data" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:206: The parameter name "dontAdopt" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:240: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/rbbi.h:241: Extra space between UParseError and &parseError [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:241: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:241: The parameter name "parseError" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:242: Extra space between UErrorCode and &status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:242: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:268: Extra space between uint32_t and ruleLength [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:268: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:269: Extra space between UErrorCode and &status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:269: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:374: Extra space between virtual and CharacterIterator& [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:391: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:423: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:449: The parameter name "n" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:613: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:614: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:697: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:759: The parameter name "c" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:774: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/ucasemap.h:22: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/ucasemap.h:23: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/ucasemap.h:269: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:270: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:271: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:300: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:301: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:302: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:329: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:330: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:331: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:381: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:419: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:420: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:421: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/chariter.h:13: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/chariter.h:14: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/chariter.h:20: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/chariter.h:96: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/chariter.h:595: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/chariter.h:608: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/chariter.h:642: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/chariter.h:671: Extra space between int32_t and pos [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/chariter.h:677: Extra space between int32_t and begin [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/chariter.h:683: Extra space between int32_t and end [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/chariter.h:687: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:692: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:697: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:702: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:707: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:712: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:717: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/schriter.h:21: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/schriter.h:29: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:52: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:63: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:64: Extra space between int32_t and textPos [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:64: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:82: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:83: Extra space between int32_t and textBegin [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:83: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:84: Extra space between int32_t and textEnd [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:84: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:85: Extra space between int32_t and textPos [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:85: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:95: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:101: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:111: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:112: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:122: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:131: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:138: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:147: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:154: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:161: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:168: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:176: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:182: Extra space between UnicodeString and text [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:182: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:20: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/udata.h:39: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:173: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:200: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:252: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:252: The parameter name "isAcceptable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/udata.h:253: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:361: The parameter name "err" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/udata.h:392: The parameter name "err" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/udata.h:426: The parameter name "access" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/text/TextBreakIterator.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 240 in 32 files If any of these errors are false positives, please file a bug against check-webkit-style.

Daniel Bates

Comment 49 2016-12-15 11:37:49 PST

Comment on attachment 297205 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297205&action=review > Source/WTF/ChangeLog:17 > + of our projects use generated sources. However, additionally, on OSes which support it, "However, additionally" => Additionally > Source/WTF/wtf/text/mac/TextBreakIteratorInternalICUMac.mm:52 > +TextBreakIterator* createIteratorForRuleSet(BreakingRuleSet ruleSet) Can we return a std::unique_ptr? > Source/WTF/wtf/text/mac/TextBreakIteratorInternalICUMac.mm:105 > + static NeverDestroyed<RuleCache> cursorMovementIterator; > + static NeverDestroyed<RuleCache> lineBreakUAX14CJKIterator; > + static NeverDestroyed<RuleCache> lineBreakUAX14NonCJKIterator; > + static NeverDestroyed<RuleCache> lineBreakUAX14LooseCJKIterator; > + static NeverDestroyed<RuleCache> lineBreakUAX14LooseNonCJKIterator; > + static NeverDestroyed<RuleCache> lineBreakUAX14NormalCJKIterator; > + static NeverDestroyed<RuleCache> lineBreakUAX14NormalNonCJKIterator; > + static NeverDestroyed<RuleCache> lineBreakUAX14StrictCJKIterator; > + static NeverDestroyed<RuleCache> lineBreakUAX14StrictNonCJKIterator; > + > + NSString *fileNameBase; > + RuleCache* cache = nullptr; > + > + switch (ruleSet) { > + case BreakingRuleSet::CursorMovement: > + fileNameBase = @"CursorMovementIteratorRules"; > + cache = &cursorMovementIterator.get(); > + break; > + case BreakingRuleSet::UAX14CJK: > + fileNameBase = @"LineBreakIteratorUAX14CJK"; > + cache = &lineBreakUAX14CJKIterator.get(); > + break; > + case BreakingRuleSet::UAX14NonCJK: > + fileNameBase = @"LineBreakIteratorUAX14NonCJK"; > + cache = &lineBreakUAX14NonCJKIterator.get(); > + break; > + case BreakingRuleSet::UAX14LooseCJK: > + fileNameBase = @"LineBreakIteratorUAX14LooseCJK"; > + cache = &lineBreakUAX14LooseCJKIterator.get(); > + break; > + case BreakingRuleSet::UAX14LooseNonCJK: > + fileNameBase = @"LineBreakIteratorUAX14LooseNonCJK"; > + cache = &lineBreakUAX14LooseNonCJKIterator.get(); > + break; > + case BreakingRuleSet::UAX14NormalCJK: > + fileNameBase = @"LineBreakIteratorUAX14NormalCJK"; > + cache = &lineBreakUAX14NormalCJKIterator.get(); > + break; > + case BreakingRuleSet::UAX14NormalNonCJK: > + fileNameBase = @"LineBreakIteratorUAX14NormalNonCJK"; > + cache = &lineBreakUAX14NormalNonCJKIterator.get(); > + break; > + case BreakingRuleSet::UAX14StrictCJK: > + fileNameBase = @"LineBreakIteratorUAX14StrictCJK"; > + cache = &lineBreakUAX14StrictCJKIterator.get(); > + break; > + case BreakingRuleSet::UAX14StrictNonCJK: > + fileNameBase = @"LineBreakIteratorUAX14StrictNonCJK"; > + cache = &lineBreakUAX14StrictNonCJKIterator.get(); > + break; > + } > + For your consideration, I suggest that we take a similar approach as in Cursor::fromType(), <http://trac.webkit.org/browser/trunk/Source/WebCore/platform/Cursor.cpp?rev=209618#L55>, and define a static function for each kind of iterator that loads the rule set file and returns a std::unique_ptr<RuleBasedBreakIterator>. Then implement this function as a switch block that effectively returns the results of calling the case-specific static function. Something like (the following code may have correctness/syntax issues): static std::unique_ptr<RuleBasedBreakIterator> breakIteratorFromResource(NSString resourceName) { NSBundle *bundle = [NSBundle bundleForClass:[WTFBundleFinder class]]; NSString *path = [bundle pathForResource:resourceName ofType:@"brk" inDirectory:@"BreakingRules"]; NSString *directory = [path stringByDeletingLastPathComponent]; if (!directory) { ASSERT_NOT_REACHED(); return nullptr; } UErrorCode errorCode = U_ZERO_ERROR; #if PLATFORM(IOS) udata_setFileAccess(UDATA_FILES_FIRST, &errorCode); if (errorCode != U_ZERO_ERROR) return nullptr; #endif LocalUDataMemoryPointer data { udata_open([directory UTF8String], "brk", [resourceName UTF8String], &errorCode) }; if (errorCode != U_ZERO_ERROR) return nullptr; #if PLATFORM(IOS) udata_setFileAccess(UDATA_DEFAULT_ACCESS, &errorCode); if (errorCode != U_ZERO_ERROR) return nullptr; #endif auto iterator = std::make_unique<RuleBasedBreakIterator>(data.orphan(), errorCode); return errorCode == U_ZERO_ERROR ? iterator : nullptr; } // FIXME: Consider using processors macros to generate these functions because they are almost identical. static RuleBasedBreakIterator* cursorMovementIterator() { static NeverDestroyed<std::unique_ptr<RuleBasedBreakIterator>> iterator = breakIteratorFromResource(@"CursorMovementIteratorRules"); return *iterator.get(); } ... static RuleBasedBreakIterator* lineBreakUAX14StrictNonCJKIterator() { static NeverDestroyed<std::unique_ptr<RuleBasedBreakIterator>> iterator = breakIteratorFromResource(@"LineBreakIteratorUAX14StrictNonCJK"); return *iterator.get(); } // FIXME: Can we return a std::unique_ptr? TextBreakIterator* createIteratorForRuleSet(BreakingRuleSet ruleSet) { std::unique_ptr<RuleBasedBreakIterator> result; switch (ruleSet) { case BreakingRuleSet::CursorMovement: result = std::make_unique<RuleBasedBreakIterator>(cursorMovementIterator()); break; ... case BreakingRuleSet::UAX14StrictNonCJK: result = std::make_unique<RuleBasedBreakIterator>(lineBreakUAX14StrictNonCJKIterator()); break; } // FIXME: Is it necessary to return a copy? return reinterpret_cast<TextBreakIterator*>(result.release()); } Alternatively, if do not expect to make use of more than 7 rule sets in a typical web surfing session (we could run an appropriate PLT suite and track how many rule sets we use) then we could write this in terms of a HashSet. Using a HashSet may simplify the code because we can take advantage of the nullity of the iterator pointer to know if loading the rule set failed and can take advantage of whether the set contains an entry to know if we ever tried to load a rule set. > Source/WTF/wtf/text/mac/TextBreakIteratorInternalICUMac.mm:148 > + return reinterpret_cast<TextBreakIterator*>(std::make_unique<RuleBasedBreakIterator>(*cache->iterator).release()); Is it necessary to make a copy?

Blaze Burg

Comment 50 2016-12-15 12:42:53 PST

Comment on attachment 297205 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297205&action=review I have some drive-by suggestions for build system changes. It looks pretty cool though! > Source/WTF/ChangeLog:31 > + * WTF.xcodeproj/project.pbxproj: Please include more fine grained details of what you changed. > Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:5912 > + 1CD1878F1D55961200CC7DEC /* BreakingRules */, It is unusual to have no file extension for an output file. Please add one unless it's a hard constraint. > Source/WTF/WTF.xcodeproj/project.pbxproj:19 > + productName = "Copy WTF Headers"; Not sure this is the right (dummy) product name. > Source/WTF/WTF.xcodeproj/project.pbxproj:512 > + 1CB4FB941D559A0D00F9FE38 /* LineBreakIteratorUAX14CJK.txt */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text; path = LineBreakIteratorUAX14CJK.txt; sourceTree = "<group>"; }; I think you need to sort the pbxproj file again. > Source/WTF/WTF.xcodeproj/project.pbxproj:1661 > + 1CD187881D55698800CC7DEC /* PBXTargetDependency */, This should be noted in the ChangeLog. > Source/WTF/WTF.xcodeproj/project.pbxproj:1699 > + 1CD187821D55695C00CC7DEC /* Generate Derived Sources */ = { This has some precedent, but I strongly prefer you make a tiny script and invoke it from this script phase, so that it's possible to review its contents easily in bugzilla. This could go in, say, WTF/Scripts/generate-wtf-derived-sources.sh > Source/WTF/wtf/DerivedSources.make:36 > + BreakingRules/CursorMovementIteratorRules.cpp \ If these two file sets are always going to be 1:1, then you should just keep the .brk list and use Make to generate the other list. BREAKING_RULES_DEFINITIONS=$(BREAKING_RULES_FILES:.brk=.cpp) > Source/WTF/wtf/DerivedSources.make:52 > +ifeq ($(WTF_PLATFORM_IOS), 1) Usually we place this inside a check of ifeq ($(OS),MACOS), but I don't know if that's actually necessary any more since only Apple ports use DerivedSources.make these days. > Source/WTF/wtf/DerivedSources.make:72 > + python $(WTF)/wtf/text/BreakingRules/GenerateBreakingRuleStrings.py cursorMovementIteratorRules $< > $@ Please put the script in $(WTF)/Scripts/ so it matches the structure used in JSC (and elsewhere). > Source/WTF/wtf/DerivedSources.make:75 > + python $(WTF)/wtf/text/BreakingRules/GenerateBreakingRuleStrings.py lineBreakIterator$*Rules $< > $@ You can add a generic rule to go from .pp to .cpp files: %.cpp : %.pp python ................. Just make sure the .cpp targets are somehow added to `all`. > Source/WTF/wtf/DerivedSources.make:80 > +BreakingRules/LineBreakIterator%.pp : $(WTF)/wtf/text/BreakingRules/LineBreakIteratorPrologue.txt $(WTF)/wtf/text/BreakingRules/LineBreakIterator%.txt $(WTF)/wtf/text/BreakingRules/LineBreakIteratorEpilogue.txt This special case rule seems unavoidable. > Source/WTF/wtf/DerivedSources.make:81 > + -cat $? | unifdef -DADDITIONAL_EMOJI_SUPPORT=$(ADDITIONAL_EMOJI_SUPPORT) -DHAVE_EXTRA_ICU_NAMED_SETS=$(HAVE_EXTRA_ICU_NAMED_SETS) -o $@ I'm pretty sure you can generate the arguments to unifdef using FEATURE_DEFINES = \ HAVE_EXTRA_ICU_NAMED_SETS \ ADDITIONAL_EMOJI_SUPPORT \ ARGS = $(foreach d,$(FEATURE_DEFINES),-D$(d)=$($d)))

Myles C. Maxfield

Comment 51 2016-12-15 15:23:50 PST

Created attachment 297232 [details] Patch

Myles C. Maxfield

Comment 52 2016-12-15 15:24:30 PST

Comment on attachment 297205 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297205&action=review >> Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:5912 >> + 1CD1878F1D55961200CC7DEC /* BreakingRules */, > > It is unusual to have no file extension for an output file. Please add one unless it's a hard constraint. This is a folder reference. The project is set up to copy the entire folder into the bundle. It has no concept of the contents of the folder (which is important because old OSes which don't have the rules compiler won't generate the byte code files) >> Source/WTF/WTF.xcodeproj/project.pbxproj:1699 >> + 1CD187821D55695C00CC7DEC /* Generate Derived Sources */ = { > > This has some precedent, but I strongly prefer you make a tiny script and invoke it from this script phase, so that it's possible to review its contents easily in bugzilla. This could go in, say, WTF/Scripts/generate-wtf-derived-sources.sh WebKit2, WebCore, and JavaScriptCore all work this way. (The WebKit project doesn't have derived sources) >> Source/WTF/wtf/DerivedSources.make:75 >> + python $(WTF)/wtf/text/BreakingRules/GenerateBreakingRuleStrings.py lineBreakIterator$*Rules $< > $@ > > You can add a generic rule to go from .pp to .cpp files: > > %.cpp : %.pp > python ................. > > Just make sure the .cpp targets are somehow added to `all`. The capitalization is different between CursorMovementIteratorRules and cursorMovementIteratorRules, so I'm not sure I can come up with that "....................." >> Source/WTF/wtf/DerivedSources.make:81 >> + -cat $? | unifdef -DADDITIONAL_EMOJI_SUPPORT=$(ADDITIONAL_EMOJI_SUPPORT) -DHAVE_EXTRA_ICU_NAMED_SETS=$(HAVE_EXTRA_ICU_NAMED_SETS) -o $@ > > I'm pretty sure you can generate the arguments to unifdef using > > FEATURE_DEFINES = \ > HAVE_EXTRA_ICU_NAMED_SETS \ > ADDITIONAL_EMOJI_SUPPORT \ > > ARGS = $(foreach d,$(FEATURE_DEFINES),-D$(d)=$($d))) Because the definition of ADDITIONAL_EMOJI_SUPPORT is different in the two blocks, I'd have to do this twice, which makes it much more verbose than just doing it inline like I've done. >> Source/WTF/wtf/text/mac/TextBreakIteratorInternalICUMac.mm:52 >> +TextBreakIterator* createIteratorForRuleSet(BreakingRuleSet ruleSet) > > Can we return a std::unique_ptr? Unfortunately, these TextBreakIterator pointers can be created/allocated by ubrk_open*() and destroyed/freed by ubrk_close(), which means that simply free() or deleting the pointers won't work in all cases. However, it should totally be possible to RAII these pointers so that we don't manually have to call ubrk_close() in closeLineBreakIterator(). That is a big enough project, though, that it should be done in a different patch. >> Source/WTF/wtf/text/mac/TextBreakIteratorInternalICUMac.mm:148 >> + return reinterpret_cast<TextBreakIterator*>(std::make_unique<RuleBasedBreakIterator>(*cache->iterator).release()); > > Is it necessary to make a copy? Unfortunately, yes. These iterators maintain internal state (for example, their current position inside a string, among other things). It is also expected for us to call this same function multiple times with the same input (there's a cache, but it has fixed size which means we may make it back to this function successive times). If we got back the exact same object, it may have leftover state from the last time it was used.

Myles C. Maxfield

Comment 53 2016-12-15 15:24:38 PST

WebKit Commit Bot

Comment 54 2016-12-15 15:25:54 PST

Attachment 297232 [details] did not pass style-queue: ERROR: Source/WTF/icu/unicode/uchriter.h:11: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/uchriter.h:18: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:59: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:60: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:78: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:79: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:80: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:81: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:90: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:96: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:107: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:117: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:124: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:133: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:142: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:152: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:163: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:173: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:182: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:191: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:201: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:214: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:221: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:228: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:237: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:247: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:259: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:269: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:280: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:289: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:298: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:309: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:322: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/uchriter.h:322: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:335: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/uchriter.h:335: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:341: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:350: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:357: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:364: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:371: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:376: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:44: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:45: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:48: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:50: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:166: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:174: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:194: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:204: The parameter name "it" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:291: The parameter name "n" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:474: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:475: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:486: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:508: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:509: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:540: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:540: The parameter name "locale" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:556: The parameter name "key" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:572: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:581: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:611: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:612: The parameter name "loc" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:613: The parameter name "loc" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:614: The parameter name "loc" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:625: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:625: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:627: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:655: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WTF/icu/unicode/umisc.h:37: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/umisc.h:42: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/umisc.h:47: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:33: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:267: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:268: Extra space between const and char [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:268: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:269: Extra space between const and char [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:270: Extra space between const and char [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:285: Extra space before last semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] ERROR: Source/WTF/icu/unicode/locid.h:303: Extra space between UBool and operator [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:313: Extra space between UBool and operator [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:359: Extra space between UErrorCode& and success [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:359: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:388: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:388: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:397: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:397: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:404: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:404: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:411: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:411: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:494: Extra space between uint32_t and getLCID [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:522: Extra space between UnicodeString& and getDisplayLanguage [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:537: Extra space between UnicodeString& and getDisplayLanguage [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:537: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:538: Extra space between UnicodeString& and dispLang [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:538: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:549: Extra space between UnicodeString& and getDisplayScript [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:549: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:565: Extra space between UnicodeString& and getDisplayScript [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:565: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:566: Extra space between UnicodeString& and dispScript [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:566: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:577: Extra space between UnicodeString& and getDisplayCountry [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:577: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:593: Extra space between UnicodeString& and getDisplayCountry [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:593: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:594: Extra space between UnicodeString& and dispCountry [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:594: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:603: Extra space between UnicodeString& and getDisplayVariant [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:603: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:613: Extra space between UnicodeString& and getDisplayVariant [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:613: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:614: Extra space between UnicodeString& and dispVar [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:614: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:627: Extra space between UnicodeString& and getDisplayName [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:627: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:641: Extra space between UnicodeString& and getDisplayName [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:641: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:642: Extra space between UnicodeString& and name [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:642: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:648: Extra space between int32_t and hashCode [whitespace/declaration] [3] ERROR: Source/WTF/icu/ unicode/locid.h:736: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/locid.h:808: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/rbbi.h:27: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/rbbi.h:39: Extra space between class and RuleBasedBreakIteratorTables [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:40: Extra space between class and BreakIterator [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:41: Extra space between class and RBBIDataWrapper [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:42: Extra space between class and UStack [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:43: Extra space between class and LanguageBreakEngine [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:44: Extra space between class and UnhandledEngine [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:72: Extra space between UText and *fText [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:79: Extra space between CharacterIterator and *fCharIter [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:99: Extra space between RBBIDataWrapper and *fData [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:104: Extra space between int32_t and fLastRuleStatusIndex [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:112: Extra space between UBool and fLastStatusIndexValid [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:119: Extra space between uint32_t and fDictionaryCharCount [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:128: Extra space between int32_t* and fCachedBreakPositions [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:134: Extra space between int32_t and fNumCachedBreakPositions [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:141: Extra space between int32_t and fPositionInCache [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:150: Extra space between UStack and *fLanguageBreakEngines [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:159: Extra space between UnhandledEngine and *fUnhandledBreakEngine [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:166: Extra space between int32_t and fBreakType [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:196: The parameter name "data" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:206: The parameter name "data" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:206: The parameter name "dontAdopt" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:240: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/rbbi.h:241: Extra space between UParseError and &parseError [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:241: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:241: The parameter name "parseError" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:242: Extra space between UErrorCode and &status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:242: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:268: Extra space between uint32_t and ruleLength [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:268: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:269: Extra space between UErrorCode and &status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:269: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:374: Extra space between virtual and CharacterIterator& [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:391: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:423: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:449: The parameter name "n" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:613: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:614: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:697: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:759: The parameter name "c" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:774: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/ucasemap.h:22: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/ucasemap.h:23: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/ucasemap.h:269: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:270: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:271: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:300: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:301: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:302: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:329: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:330: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:331: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:381: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:419: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:420: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:421: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/chariter.h:13: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/chariter.h:14: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/chariter.h:20: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/chariter.h:96: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/chariter.h:595: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/chariter.h:608: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/chariter.h:642: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/chariter.h:671: Extra space between int32_t and pos [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/chariter.h:677: Extra space between int32_t and begin [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/chariter.h:683: Extra space between int32_t and end [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/chariter.h:687: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:692: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:697: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:702: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:707: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:712: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:717: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/schriter.h:21: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/schriter.h:29: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:52: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:63: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:64: Extra space between int32_t and textPos [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:64: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:82: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:83: Extra space between int32_t and textBegin [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:83: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:84: Extra space between int32_t and textEnd [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:84: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:85: Extra space between int32_t and textPos [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:85: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:95: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:101: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:111: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:112: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:122: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:131: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:138: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:147: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:154: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:161: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:168: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:176: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:182: Extra space between UnicodeString and text [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:182: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:20: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/udata.h:39: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:173: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:200: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:252: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:252: The parameter name "isAcceptable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/udata.h:253: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:361: The parameter name "err" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/udata.h:392: The parameter name "err" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/udata.h:426: The parameter name "access" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/text/TextBreakIterator.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 240 in 32 files If any of these errors are false positives, please file a bug against check-webkit-style.

Myles C. Maxfield

Comment 55 2016-12-15 16:50:04 PST

Comment on attachment 297232 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297232&action=review > Source/WTF/Scripts/GenerateBreakingRuleStrings.py:72 > + print("// WTF/wtf/text/BreakingRules/GenerateBreakingRuleStrings.py") This is no longer accurate.

Myles C. Maxfield

Comment 56 2016-12-15 18:09:08 PST

Created attachment 297271 [details] Patch

WebKit Commit Bot

Comment 57 2016-12-15 18:11:26 PST

Attachment 297271 [details] did not pass style-queue: ERROR: Source/WTF/icu/unicode/uchriter.h:11: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/uchriter.h:18: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:59: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:60: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:78: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:79: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:80: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:81: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:90: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:96: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:106: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:107: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:117: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:124: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:133: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:142: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:152: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:163: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:173: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:182: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:191: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:201: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:214: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:221: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:228: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:237: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:247: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:259: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:269: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:280: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:289: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:298: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:309: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:322: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/uchriter.h:322: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:335: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/uchriter.h:335: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:341: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:350: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:357: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:364: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:371: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/uchriter.h:376: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:44: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:45: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:48: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:50: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:166: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:174: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:194: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:204: The parameter name "it" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:291: The parameter name "n" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:474: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:475: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:486: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:508: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:509: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:540: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:540: The parameter name "locale" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:556: The parameter name "key" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:572: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:581: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:611: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/brkiter.h:612: The parameter name "loc" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:613: The parameter name "loc" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:614: The parameter name "loc" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:625: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:625: Missing space inside { }. [whitespace/braces] [5] ERROR: Source/WTF/icu/unicode/brkiter.h:627: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/brkiter.h:655: Should have a space between // and comment [whitespace/comments] [4] ERROR: Source/WTF/icu/unicode/umisc.h:37: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/umisc.h:42: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/umisc.h:47: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:32: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:33: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:36: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/locid.h:267: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:268: Extra space between const and char [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:268: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:269: Extra space between const and char [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:270: Extra space between const and char [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:285: Extra space before last semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5] ERROR: Source/WTF/icu/unicode/locid.h:303: Extra space between UBool and operator [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:313: Extra space between UBool and operator [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:359: Extra space between UErrorCode& and success [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:359: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:388: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:388: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:397: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:397: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:404: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:404: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:411: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:411: Extra space before ) [whitespace/parens] [2] ERROR: Source/WTF/icu/unicode/locid.h:494: Extra space between uint32_t and getLCID [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:522: Extra space between UnicodeString& and getDisplayLanguage [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:537: Extra space between UnicodeString& and getDisplayLanguage [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:537: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:538: Extra space between UnicodeString& and dispLang [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:538: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:549: Extra space between UnicodeString& and getDisplayScript [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:549: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:565: Extra space between UnicodeString& and getDisplayScript [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:565: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:566: Extra space between UnicodeString& and dispScript [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:566: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:577: Extra space between UnicodeString& and getDisplayCountry [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:577: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:593: Extra space between UnicodeString& and getDisplayCountry [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:593: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:594: Extra space between UnicodeString& and dispCountry [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:594: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:603: Extra space between UnicodeString& and getDisplayVariant [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:603: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:613: Extra space between UnicodeString& and getDisplayVariant [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:613: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:614: Extra space between UnicodeString& and dispVar [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:614: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:627: Extra space between UnicodeString& and getDisplayName [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:627: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:641: Extra space between UnicodeString& and getDisplayName [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:641: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/locid.h:642: Extra space between UnicodeString& and name [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/locid.h:642: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/locid.h:648: Extra space between int32_t and hashCode [whitespace/declaration] [3] ERROR: Source/WTF/icu/ unicode/locid.h:736: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/locid.h:808: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/rbbi.h:27: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/rbbi.h:39: Extra space between class and RuleBasedBreakIteratorTables [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:40: Extra space between class and BreakIterator [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:41: Extra space between class and RBBIDataWrapper [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:42: Extra space between class and UStack [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:43: Extra space between class and LanguageBreakEngine [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:44: Extra space between class and UnhandledEngine [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:72: Extra space between UText and *fText [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:79: Extra space between CharacterIterator and *fCharIter [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:99: Extra space between RBBIDataWrapper and *fData [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:104: Extra space between int32_t and fLastRuleStatusIndex [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:112: Extra space between UBool and fLastStatusIndexValid [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:119: Extra space between uint32_t and fDictionaryCharCount [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:128: Extra space between int32_t* and fCachedBreakPositions [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:134: Extra space between int32_t and fNumCachedBreakPositions [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:141: Extra space between int32_t and fPositionInCache [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:150: Extra space between UStack and *fLanguageBreakEngines [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:159: Extra space between UnhandledEngine and *fUnhandledBreakEngine [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:166: Extra space between int32_t and fBreakType [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:196: The parameter name "data" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:206: The parameter name "data" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:206: The parameter name "dontAdopt" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:240: Extra space after ( in function call [whitespace/parens] [4] ERROR: Source/WTF/icu/unicode/rbbi.h:241: Extra space between UParseError and &parseError [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:241: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:241: The parameter name "parseError" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:242: Extra space between UErrorCode and &status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:242: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:268: Extra space between uint32_t and ruleLength [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:268: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:269: Extra space between UErrorCode and &status [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:269: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:374: Extra space between virtual and CharacterIterator& [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:391: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:423: The parameter name "text" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:449: The parameter name "n" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:613: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:614: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/rbbi.h:697: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:759: The parameter name "c" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/rbbi.h:774: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/ucasemap.h:22: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/ucasemap.h:23: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/ucasemap.h:269: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:270: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:271: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:300: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:301: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:302: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:329: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:330: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:331: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:381: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:419: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:420: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/ucasemap.h:421: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/chariter.h:13: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/chariter.h:14: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/chariter.h:20: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/chariter.h:96: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WTF/icu/unicode/chariter.h:595: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/chariter.h:608: The parameter name "origin" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/chariter.h:642: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/chariter.h:671: Extra space between int32_t and pos [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/chariter.h:677: Extra space between int32_t and begin [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/chariter.h:683: Extra space between int32_t and end [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/chariter.h:687: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:692: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:697: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:702: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:707: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:712: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/chariter.h:717: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WTF/icu/unicode/schriter.h:21: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/schriter.h:29: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:52: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:63: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:64: Extra space between int32_t and textPos [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:64: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:82: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:83: Extra space between int32_t and textBegin [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:83: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:84: Extra space between int32_t and textEnd [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:84: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:85: Extra space between int32_t and textPos [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:85: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:95: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:101: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:111: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:112: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:122: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:131: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:138: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:147: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:154: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:161: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:168: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:176: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/schriter.h:182: Extra space between UnicodeString and text [whitespace/declaration] [3] ERROR: Source/WTF/icu/unicode/schriter.h:182: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:20: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/icu/unicode/udata.h:39: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:173: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:200: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:252: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:252: The parameter name "isAcceptable" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/udata.h:253: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/icu/unicode/udata.h:361: The parameter name "err" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/udata.h:392: The parameter name "err" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/icu/unicode/udata.h:426: The parameter name "access" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WTF/wtf/text/TextBreakIterator.h:36: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 240 in 32 files If any of these errors are false positives, please file a bug against check-webkit-style.

Myles C. Maxfield

Comment 58 2016-12-15 23:49:34 PST

Comment on attachment 297271 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=297271&action=review > Source/WTF/wtf/text/TextBreakIterator.cpp:182 > + static TextBreakIterator* staticCursorMovementIterator = createCursorMovementIteratorWithFallback(); This should be NeverDestroyed. > Source/WTF/wtf/text/TextBreakIterator.cpp:185 > static TextBreakIterator* staticCursorMovementIterator = initializeIterator(UBRK_CHARACTER, "th"); This should be NeverDestroyed.

Myles C. Maxfield

Comment 59 2016-12-16 01:02:46 PST

Created attachment 297306 [details] WIP

Myles C. Maxfield

Comment 60 2016-12-16 16:56:45 PST

Comment on attachment 297306 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=297306&action=review > Source/WTF/Scripts/GenerateBreakingRuleStrings.py:70 > + print("") Use ''' > Source/WTF/Scripts/GenerateBreakingRuleStrings.py:72 > + print("// WTF/wtf/text/BreakingRules/GenerateBreakingRuleStrings.py") You can use argv[0] > Source/WTF/Scripts/GenerateBreakingRuleStrings.py:83 > + print("const char* " + symbolName + " = ") string interpolation (string.format or like printf format) > Source/WTF/wtf/DerivedSources.make:69 > + -unifdef -DADDITIONAL_EMOJI_SUPPORT=$(ADDITIONAL_EMOJI_SUPPORT_FOR_CURSOR_MOVEMENT) -DHAVE_EXTRA_ICU_NAMED_SETS=$(HAVE_EXTRA_ICU_NAMED_SETS) -o $@ $< Write a comment about how the cmake file doesn't do this unifdef. Or do this in python directly > Source/WTF/wtf/text/mac/TextBreakIteratorInternalICUMac.mm:31 > +#include <unicode/rbbi.h> Maybe copy headers around into every directory > Source/WTF/wtf/text/mac/TextBreakIteratorInternalICUMac.mm:51 > + if (!path) Move this down.

Myles C. Maxfield

Comment 61 2016-12-20 11:01:04 PST

Myles C. Maxfield

Comment 62 2016-12-20 11:04:14 PST

Comment on attachment 297306 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=297306&action=review >> Source/WTF/wtf/DerivedSources.make:69 >> + -unifdef -DADDITIONAL_EMOJI_SUPPORT=$(ADDITIONAL_EMOJI_SUPPORT_FOR_CURSOR_MOVEMENT) -DHAVE_EXTRA_ICU_NAMED_SETS=$(HAVE_EXTRA_ICU_NAMED_SETS) -o $@ $< > > Write a comment about how the cmake file doesn't do this unifdef. Or do this in python directly It looks like we don't have a C preprocessor in webkitpy, and I'd rather not rewrite this script in Perl. It also doesn't look like there's one that comes as part of a standard Python install on macOS.

Myles C. Maxfield

Comment 63 2017-01-05 15:47:08 PST

Comment on attachment 297306 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=297306&action=review > Source/WTF/wtf/text/BreakingRules/CursorMovementIteratorRules.txt:77 > + $EmojiForMods = [\u261D \u26F9 \u270A-\u270D \U0001F385 \U0001F3C3-\U0001F3C4 \U0001F3CA \U0001F3CB \U0001F442-\U0001F443 \U0001F446-\U0001F450 \U0001F466-\U0001F469 \U0001F46E-\U0001F478 \U0001F47C \U0001F481-\U0001F483 \U0001F485-\U0001F487 \U0001F4AA \U0001F575 \U0001F590 \U0001F595 \U0001F596 \U0001F645-\U0001F647 \U0001F64B-\U0001F64F \U0001F6A3 \U0001F6B4-\U0001F6B6 \U0001F6C0 \U0001F918] ; # Emoji that take Fitzpatrick modifiers See https://bugs.webkit.org/show_bug.cgi?id=166711 > Source/WTF/wtf/text/BreakingRules/LineBreakIteratorEpilogue.txt:81 > + $EmojiForMods = [\u261D \u26F9 \u270A-\u270D \U0001F385 \U0001F3C3-\U0001F3C4 \U0001F3CA \U0001F3CB \U0001F442-\U0001F443 \U0001F446-\U0001F450 \U0001F466-\U0001F469 \U0001F46E-\U0001F478 \U0001F47C \U0001F481-\U0001F483 \U0001F485-\U0001F487 \U0001F4AA \U0001F575 \U0001F590 \U0001F595 \U0001F596 \U0001F645-\U0001F647 \U0001F64B-\U0001F64F \U0001F6A3 \U0001F6B4-\U0001F6B6 \U0001F6C0 \U0001F918] ; # Emoji that take Fitzpatrick modifiers See https://bugs.webkit.org/show_bug.cgi?id=166711 > Source/WTF/wtf/text/mac/TextBreakIteratorInternalICUMac.mm:63 > + LocalUDataMemoryPointer data(udata_open([directory UTF8String], "brk", [fileNameBase UTF8String], &errorCode)); This code path should only be used on internal builds.

Myles C. Maxfield

Comment 64 2017-01-18 14:16:23 PST

We're blocked on new ICU API: http://bugs.icu-project.org/trac/ticket/12914

Myles C. Maxfield

Comment 65 2017-02-07 18:00:18 PST

Created attachment 300869 [details] WIP

Myles C. Maxfield

Comment 66 2017-02-08 11:59:44 PST

Created attachment 300934 [details] WIP

WebKit Commit Bot

Comment 67 2017-02-08 12:02:19 PST

Attachment 300934 [details] did not pass style-queue: ERROR: Source/WTF/wtf/text/TextBreakIterator.h:34: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 1 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.

Myles C. Maxfield

Comment 68 2017-02-08 13:03:53 PST

Created attachment 300943 [details] Patch

WebKit Commit Bot

Comment 69 2017-02-08 13:07:17 PST

Attachment 300943 [details] did not pass style-queue: ERROR: Source/WTF/wtf/text/TextBreakIterator.h:34: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 1 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.

Myles C. Maxfield

Comment 70 2017-02-08 13:14:43 PST

Created attachment 300947 [details] Patch

WebKit Commit Bot

Comment 71 2017-02-08 13:36:59 PST

Attachment 300947 [details] did not pass style-queue: ERROR: Source/WTF/wtf/text/TextBreakIterator.h:34: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 1 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 72 2017-02-08 14:09:49 PST

Comment on attachment 300947 [details] Patch Attachment 300947 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3027240 Number of test failures exceeded the failure limit.

Build Bot

Comment 73 2017-02-08 14:09:56 PST

Created attachment 300960 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Myles C. Maxfield

Comment 74 2017-02-08 14:14:33 PST

Created attachment 300964 [details] Patch

WebKit Commit Bot

Comment 75 2017-02-08 14:18:06 PST

Attachment 300964 [details] did not pass style-queue: ERROR: Source/WTF/wtf/text/TextBreakIterator.h:34: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 1 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.

Myles C. Maxfield

Comment 76 2017-02-08 14:26:17 PST

Created attachment 300966 [details] Patch

WebKit Commit Bot

Comment 77 2017-02-08 14:29:43 PST

Attachment 300966 [details] did not pass style-queue: ERROR: Source/WTF/wtf/text/TextBreakIterator.h:34: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 1 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.

Myles C. Maxfield

Comment 78 2017-02-09 15:03:48 PST

Created attachment 301090 [details] Patch

Myles C. Maxfield

Comment 79 2017-02-09 16:03:10 PST

Created attachment 301096 [details] Patch

WebKit Commit Bot

Comment 80 2017-02-09 16:05:35 PST

Attachment 301096 [details] did not pass style-queue: ERROR: Source/WTF/wtf/text/TextBreakIterator.h:34: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 1 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.

Myles C. Maxfield

Comment 81 2017-02-09 16:08:17 PST

Created attachment 301097 [details] Patch

WebKit Commit Bot

Comment 82 2017-02-09 16:11:19 PST

Attachment 301097 [details] did not pass style-queue: ERROR: Source/WTF/wtf/text/TextBreakIterator.h:34: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] Total errors found: 1 in 24 files If any of these errors are false positives, please file a bug against check-webkit-style.

Jonathan Bedard

Comment 83 2017-02-10 10:29:33 PST

(In reply to comment #82) > Attachment 301097 [details] did not pass style-queue: > > > ERROR: Source/WTF/wtf/text/TextBreakIterator.h:34: enum members should use > InterCaps with an initial capital letter or initial 'k' for C-style enums. > [readability/enum_casing] [4] > Total errors found: 1 in 24 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. I don't think it's worth trying to make an exception in the style-checker for these kinds of variables. We would need an acronym detector. Something like: Uax14CJK would satisfy the style checker.

Myles C. Maxfield

Comment 84 2017-02-10 15:33:34 PST

Comment on attachment 301097 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301097&action=review > Source/WTF/wtf/text/mac/TextBreakIteratorInternalICUMac.mm:50 > + NSString *path = [bundle pathForResource:fileNameBase ofType:@"brk" inDirectory:@"BreakingRules"]; Do this without file IO.

Myles C. Maxfield

Comment 85 2017-02-10 18:08:05 PST

Created attachment 301230 [details] Reduce filesystem access

Myles C. Maxfield

Comment 86 2017-02-13 11:54:54 PST

Created attachment 301367 [details] Patch

Myles C. Maxfield

Comment 87 2017-02-13 16:34:01 PST

Comment on attachment 301367 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=301367&action=review > Source/WTF/wtf/DerivedSources.make:49 > +BreakingRules/CursorMovementIteratorRules.cpp : $(WTF)/wtf/text/BreakingRules/CursorMovementIteratorRules.txt Probably shouldn't put the .cpp files in the folder which gets included in the bundle.

Myles C. Maxfield

Comment 88 2017-02-13 17:34:56 PST

Created attachment 301425 [details] Patch

Myles C. Maxfield

Comment 89 2017-02-13 17:37:23 PST

Created attachment 301426 [details] Patch

Myles C. Maxfield

Comment 90 2017-02-13 17:56:00 PST

Created attachment 301429 [details] Patch

Myles C. Maxfield

Comment 91 2017-02-26 16:39:03 PST

After r213020, we no longer use custom ICU breaking iterators.

mitz

Comment 92 2017-03-05 14:41:24 PST

Comment on attachment 301429 [details] Patch Removing the review? flag because the bug’s status is “resolved”.

Note You need to log in before you can comment on or make changes to this bug.