Bug 160625

Summary:

Add LEBDecoder and tests

Product:

WebKit

Reporter:

Keith Miller <keith_miller>

Component:

New Bugs

Assignee:

Keith Miller <keith_miller>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, cmarcelo, commit-queue, mark.lam, msaboff, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Keith Miller

Reported 2016-08-05 19:26:03 PDT

Add LEBDecoder and tests

Attachments
Patch (25.45 KB, patch) 2016-08-05 19:29 PDT, Keith Miller	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Keith Miller

Comment 1 2016-08-05 19:29:42 PDT

Created attachment 285475 [details] Patch

WebKit Commit Bot

Comment 2 2016-08-05 19:30:59 PDT

Attachment 285475 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/testWASM.cpp:74: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/testWASM.cpp:82: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/testWASM.cpp:87: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/testWASM.cpp:93: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/testWASM.cpp:99: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/testWASM.cpp:103: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/testWASM.cpp:122: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/testWASM.cpp:130: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/testWASM.cpp:135: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/testWASM.cpp:141: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/testWASM.cpp:147: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/JavaScriptCore/testWASM.cpp:151: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WTF/wtf/LEBDecoder.h:32: Bad include order. Mixing system and custom headers. [build/include_order] [4] Total errors found: 13 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

Keith Miller

Comment 3 2016-08-05 20:28:26 PDT

(In reply to comment #2) > Attachment 285475 [details] did not pass style-queue: > > > ERROR: Source/JavaScriptCore/testWASM.cpp:74: Weird number of spaces at > line-start. Are you using a 4-space indent? [whitespace/indent] [3] > ERROR: Source/JavaScriptCore/testWASM.cpp:82: Weird number of spaces at > line-start. Are you using a 4-space indent? [whitespace/indent] [3] > ERROR: Source/JavaScriptCore/testWASM.cpp:87: Weird number of spaces at > line-start. Are you using a 4-space indent? [whitespace/indent] [3] > ERROR: Source/JavaScriptCore/testWASM.cpp:93: Weird number of spaces at > line-start. Are you using a 4-space indent? [whitespace/indent] [3] > ERROR: Source/JavaScriptCore/testWASM.cpp:99: Weird number of spaces at > line-start. Are you using a 4-space indent? [whitespace/indent] [3] > ERROR: Source/JavaScriptCore/testWASM.cpp:103: Weird number of spaces at > line-start. Are you using a 4-space indent? [whitespace/indent] [3] > ERROR: Source/JavaScriptCore/testWASM.cpp:122: Weird number of spaces at > line-start. Are you using a 4-space indent? [whitespace/indent] [3] > ERROR: Source/JavaScriptCore/testWASM.cpp:130: Weird number of spaces at > line-start. Are you using a 4-space indent? [whitespace/indent] [3] > ERROR: Source/JavaScriptCore/testWASM.cpp:135: Weird number of spaces at > line-start. Are you using a 4-space indent? [whitespace/indent] [3] > ERROR: Source/JavaScriptCore/testWASM.cpp:141: Weird number of spaces at > line-start. Are you using a 4-space indent? [whitespace/indent] [3] > ERROR: Source/JavaScriptCore/testWASM.cpp:147: Weird number of spaces at > line-start. Are you using a 4-space indent? [whitespace/indent] [3] > ERROR: Source/JavaScriptCore/testWASM.cpp:151: Weird number of spaces at > line-start. Are you using a 4-space indent? [whitespace/indent] [3] > ERROR: Source/WTF/wtf/LEBDecoder.h:32: Bad include order. Mixing system and > custom headers. [build/include_order] [4] > Total errors found: 13 in 6 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. The style checker doesn't seem to like the comments in the macros.

WebKit Commit Bot

Comment 4 2016-08-05 20:49:34 PDT

Comment on attachment 285475 [details] Patch Clearing flags on attachment: 285475 Committed r204218: <http://trac.webkit.org/changeset/204218>

WebKit Commit Bot

Comment 5 2016-08-05 20:49:38 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.