Bug 160618 – WTF needs a variant implementation

• Component: New Bugs
• Status: RESOLVED FIXED

[Sam Weinig]

WTF needs a variant implementation

[Sam Weinig]

Created attachment 285468 [details]
Patch

[Sam Weinig]

Created attachment 285473 [details]
Patch

[Alex Christensen]

Comment on attachment 285473 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285473&action=review

Sweeeeet!

> Tools/TestWebKitAPI/Tests/WTF/Variant.cpp:47
> +    typedef std::experimental::variant<int, float, String> Variant;

Do we want to type std::experimental::variant every time we use this in WebKit, or do we want to put this line in the header?

[Sam Weinig]

(In reply to comment #3)
> Comment on attachment 285473 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=285473&action=review
> 
> Sweeeeet!
> 
> > Tools/TestWebKitAPI/Tests/WTF/Variant.cpp:47
> > +    typedef std::experimental::variant<int, float, String> Variant;
> 
> Do we want to type std::experimental::variant every time we use this in
> WebKit, or do we want to put this line in the header?

I think for now we want to type it. As I start using it, if it becomes annoying, I will consider adding something like:

namespace WTF {

template<typename ... Types>
using Variant = std::experimental::variant<Types>;

}

But I want to see first.

[WebKit Commit Bot]

Comment on attachment 285473 [details]
Patch

Clearing flags on attachment: 285473

Committed r204227: <http://trac.webkit.org/changeset/204227>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

The failures in bug 160638 make it seem likely this is not quite working yet in the compilers used on the GTK and Windows bots.