Summary: | Create platform/gamepads directory, and make GamepadProvider pure virtual (with a default empty implementation) | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||
Component: | WebCore Misc. | Assignee: | Brady Eidson <beidson> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | achristensen, commit-queue, ossy | ||||||||
Priority: | P2 | ||||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 134076, 134675 | ||||||||||
Attachments: |
|
Description
Brady Eidson
2016-08-05 09:54:55 PDT
Created attachment 285426 [details]
Patch
Attachment 285426 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/gamepads/mac/HIDGamepad.cpp:73: Use nullptr instead of NULL. [readability/null] [5]
Total errors found: 1 in 20 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 285428 [details]
Patch
Attachment 285428 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/gamepad/mac/HIDGamepad.cpp:73: Use nullptr instead of NULL. [readability/null] [5]
Total errors found: 1 in 20 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 285433 [details]
Patch
Attachment 285433 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/gamepad/mac/HIDGamepad.cpp:73: Use nullptr instead of NULL. [readability/null] [5]
Total errors found: 1 in 21 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 285433 [details] Patch Clearing flags on attachment: 285433 Committed r204178: <http://trac.webkit.org/changeset/204178> All reviewed patches have been landed. Closing bug. (In reply to comment #7) > Comment on attachment 285433 [details] > Patch > > Clearing flags on attachment: 285433 > > Committed r204178: <http://trac.webkit.org/changeset/204178> It broke the Apple Mac cmake build. |