Bug 160599

Summary: Create platform/gamepads directory, and make GamepadProvider pure virtual (with a default empty implementation)
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, ossy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 134076, 134675    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Brady Eidson 2016-08-05 09:54:55 PDT
Create platform/gamepads directory, and make GamepadProvider pure virtual (with a default empty implementation)
Comment 1 Brady Eidson 2016-08-05 10:04:22 PDT
Created attachment 285426 [details]
Patch
Comment 2 WebKit Commit Bot 2016-08-05 10:06:24 PDT
Attachment 285426 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/gamepads/mac/HIDGamepad.cpp:73:  Use nullptr instead of NULL.  [readability/null] [5]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brady Eidson 2016-08-05 10:17:35 PDT
Created attachment 285428 [details]
Patch
Comment 4 WebKit Commit Bot 2016-08-05 10:20:31 PDT
Attachment 285428 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/gamepad/mac/HIDGamepad.cpp:73:  Use nullptr instead of NULL.  [readability/null] [5]
Total errors found: 1 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Brady Eidson 2016-08-05 10:36:49 PDT
Created attachment 285433 [details]
Patch
Comment 6 WebKit Commit Bot 2016-08-05 10:39:35 PDT
Attachment 285433 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/gamepad/mac/HIDGamepad.cpp:73:  Use nullptr instead of NULL.  [readability/null] [5]
Total errors found: 1 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 WebKit Commit Bot 2016-08-05 11:29:12 PDT
Comment on attachment 285433 [details]
Patch

Clearing flags on attachment: 285433

Committed r204178: <http://trac.webkit.org/changeset/204178>
Comment 8 WebKit Commit Bot 2016-08-05 11:29:17 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Csaba Osztrogonác 2016-08-08 03:25:45 PDT
(In reply to comment #7)
> Comment on attachment 285433 [details]
> Patch
> 
> Clearing flags on attachment: 285433
> 
> Committed r204178: <http://trac.webkit.org/changeset/204178>

It broke the Apple Mac cmake build.