Bug 160599

Summary: Create platform/gamepads directory, and make GamepadProvider pure virtual (with a default empty implementation)
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebCore Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, ossy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 134076, 134675    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Brady Eidson
Reported 2016-08-05 09:54:55 PDT
Create platform/gamepads directory, and make GamepadProvider pure virtual (with a default empty implementation)
Attachments
Patch (154.58 KB, patch)
2016-08-05 10:04 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (154.51 KB, patch)
2016-08-05 10:17 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Patch (156.64 KB, patch)
2016-08-05 10:36 PDT, Brady Eidson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2016-08-05 10:04:22 PDT
Created attachment 285426 [details] Patch
WebKit Commit Bot
Comment 2 2016-08-05 10:06:24 PDT
Attachment 285426 [details] did not pass style-queue: ERROR: Source/WebCore/platform/gamepads/mac/HIDGamepad.cpp:73: Use nullptr instead of NULL. [readability/null] [5] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 3 2016-08-05 10:17:35 PDT
Created attachment 285428 [details] Patch
WebKit Commit Bot
Comment 4 2016-08-05 10:20:31 PDT
Attachment 285428 [details] did not pass style-queue: ERROR: Source/WebCore/platform/gamepad/mac/HIDGamepad.cpp:73: Use nullptr instead of NULL. [readability/null] [5] Total errors found: 1 in 20 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brady Eidson
Comment 5 2016-08-05 10:36:49 PDT
Created attachment 285433 [details] Patch
WebKit Commit Bot
Comment 6 2016-08-05 10:39:35 PDT
Attachment 285433 [details] did not pass style-queue: ERROR: Source/WebCore/platform/gamepad/mac/HIDGamepad.cpp:73: Use nullptr instead of NULL. [readability/null] [5] Total errors found: 1 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 7 2016-08-05 11:29:12 PDT
Comment on attachment 285433 [details] Patch Clearing flags on attachment: 285433 Committed r204178: <http://trac.webkit.org/changeset/204178>
WebKit Commit Bot
Comment 8 2016-08-05 11:29:17 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 9 2016-08-08 03:25:45 PDT
(In reply to comment #7) > Comment on attachment 285433 [details] > Patch > > Clearing flags on attachment: 285433 > > Committed r204178: <http://trac.webkit.org/changeset/204178> It broke the Apple Mac cmake build.
Note You need to log in before you can comment on or make changes to this bug.