Bug 160598
| Summary: | page/Chrome.cpp: Add ASSERT(frame) to catch nulls and eventually change frame from pointer to reference | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | John Wilander <wilander> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | ||
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
John Wilander
Brent Fulgham pointed the following out regarding page/Chrome.cpp:
It looks like frame is assumed to be non-null most places it is used. We should probably make it a reference in a future patch to help enforce this. I think we should add an "ASSERT(frame)" so we can catch cases where this assumption is not true.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |