Bug 160567

Summary: Move insertAdjacent*() API from HTMLElement to Element
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cmarcelo, commit-queue, darin, esprehn+autocc, gyuyoung.kim, kangil.han, kondapallykalyan, rniwa, sam
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2016-08-04 13:58:19 PDT
Move insertAdjacent*() API from HTMLElement to Element: - https://w3c.github.io/DOM-Parsing/#extensions-to-the-element-interface - https://dom.spec.whatwg.org/#element Firefox and Chrome both have insertAdjacentHTML() on Element. Chrome has insertAdjacentText() / insertAdjacentElement() on Element as well. Firefox does not have this API at all.
Attachments
Patch (23.04 KB, patch)
2016-08-04 14:05 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (24.23 KB, patch)
2016-08-04 14:40 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (22.81 KB, patch)
2016-08-04 15:25 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-08-04 14:05:21 PDT
Created attachment 285362 [details] Patch
Chris Dumez
Comment 2 2016-08-04 14:40:42 PDT
Created attachment 285366 [details] Patch
WebKit Commit Bot
Comment 3 2016-08-04 15:22:15 PDT
Comment on attachment 285366 [details] Patch Rejecting attachment 285366 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 285366, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: curity/cross-frame-access-put-expected.txt Hunk #1 FAILED at 72. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/http/tests/security/cross-frame-access-put-expected.txt.rej patching file LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt patching file LayoutTests/imported/w3c/web-platform-tests/domparsing/insert_adjacent_html-expected.txt Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/1813570
Chris Dumez
Comment 4 2016-08-04 15:25:11 PDT
Created attachment 285372 [details] Patch
WebKit Commit Bot
Comment 5 2016-08-04 15:45:12 PDT
Comment on attachment 285372 [details] Patch Clearing flags on attachment: 285372 Committed r204150: <http://trac.webkit.org/changeset/204150>
WebKit Commit Bot
Comment 6 2016-08-04 15:45:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.