Bug 160567 - Move insertAdjacent*() API from HTMLElement to Element
Summary: Move insertAdjacent*() API from HTMLElement to Element
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2016-08-04 13:58 PDT by Chris Dumez
Modified: 2016-08-04 15:45 PDT (History)
10 users (show)

See Also:


Attachments
Patch (23.04 KB, patch)
2016-08-04 14:05 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (24.23 KB, patch)
2016-08-04 14:40 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (22.81 KB, patch)
2016-08-04 15:25 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-08-04 13:58:19 PDT
Move insertAdjacent*() API from HTMLElement to Element:
- https://w3c.github.io/DOM-Parsing/#extensions-to-the-element-interface
- https://dom.spec.whatwg.org/#element

Firefox and Chrome both have insertAdjacentHTML() on Element.
Chrome has insertAdjacentText() / insertAdjacentElement() on Element as well. Firefox does not have this API at all.
Comment 1 Chris Dumez 2016-08-04 14:05:21 PDT
Created attachment 285362 [details]
Patch
Comment 2 Chris Dumez 2016-08-04 14:40:42 PDT
Created attachment 285366 [details]
Patch
Comment 3 WebKit Commit Bot 2016-08-04 15:22:15 PDT
Comment on attachment 285366 [details]
Patch

Rejecting attachment 285366 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 285366, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
curity/cross-frame-access-put-expected.txt
Hunk #1 FAILED at 72.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/http/tests/security/cross-frame-access-put-expected.txt.rej
patching file LayoutTests/imported/w3c/web-platform-tests/dom/interfaces-expected.txt
patching file LayoutTests/imported/w3c/web-platform-tests/domparsing/insert_adjacent_html-expected.txt

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/1813570
Comment 4 Chris Dumez 2016-08-04 15:25:11 PDT
Created attachment 285372 [details]
Patch
Comment 5 WebKit Commit Bot 2016-08-04 15:45:12 PDT
Comment on attachment 285372 [details]
Patch

Clearing flags on attachment: 285372

Committed r204150: <http://trac.webkit.org/changeset/204150>
Comment 6 WebKit Commit Bot 2016-08-04 15:45:17 PDT
All reviewed patches have been landed.  Closing bug.