Bug 160530

Summary: Drop DocumentType.internalSubset attribute
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin, dbates, rniwa, sam
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://dom.spec.whatwg.org/#documenttype
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2016-08-03 15:52:27 PDT
Drop DocumentType.internalSubset attribute. It is no longer in the DOM specification, and other browsers have already dropped it. In WebKit, it is always null anyway.
Attachments
Patch (12.77 KB, patch)
2016-08-03 16:11 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-08-03 16:11:35 PDT
Created attachment 285288 [details] Patch
Alex Christensen
Comment 2 2016-08-03 21:51:49 PDT
Comment on attachment 285288 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285288&action=review > Source/WebCore/bindings/objc/DOMDocumentType.mm:77 > - return IMPL->internalSubset(); > + return IMPL->internalSubsetForBindings(); What are the implications of keeping the objc bindings when the javascript bindings are gone? Before we started freezing the objc bindings, wouldn't we have removed the whole method?
WebKit Commit Bot
Comment 3 2016-08-03 22:12:46 PDT
Comment on attachment 285288 [details] Patch Clearing flags on attachment: 285288 Committed r204114: <http://trac.webkit.org/changeset/204114>
WebKit Commit Bot
Comment 4 2016-08-03 22:12:51 PDT
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 5 2016-08-04 09:03:12 PDT
(In reply to comment #2) > Comment on attachment 285288 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=285288&action=review > > > Source/WebCore/bindings/objc/DOMDocumentType.mm:77 > > - return IMPL->internalSubset(); > > + return IMPL->internalSubsetForBindings(); > > What are the implications of keeping the objc bindings when the javascript > bindings are gone? Before we started freezing the objc bindings, wouldn't > we have removed the whole method? No, before the freeze, we wouldn't have been able to remove the whole method. After the freeze though we would in theory be able to remove the internalSubsetForBindings() method and hack the ObjC bindings to stop calling it. However, this is usually not possible because of GObject bindings.
Note You need to log in before you can comment on or make changes to this bug.