Bug 160513

Summary: Fix logging in W3C tests
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, cdumez, darin, dbates, rniwa, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2016-08-03 10:41:20 PDT
Fix logging in W3C tests. Some W3C tests have no visible output or output in the wrong order because we fail to use the test's log <div> and always append the log lines to the body.
Attachments
Patch (224.16 KB, patch)
2016-08-03 10:49 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (229.86 KB, patch)
2016-08-03 11:01 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-08-03 10:43:13 PDT
Unfortunately, a lot of tests need to be rebaselined..
Chris Dumez
Comment 2 2016-08-03 10:49:51 PDT
Created attachment 285247 [details] Patch
Chris Dumez
Comment 3 2016-08-03 11:01:57 PDT
Created attachment 285249 [details] Patch
Chris Dumez
Comment 4 2016-08-03 11:03:26 PDT
Comment on attachment 285249 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285249&action=review > LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-childElementCount-expected.txt:5 > +The result of this test is given above. Note that this test makes sense now. > LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-insertAdjacentElement-expected.txt:4 > +PASS Inserted element should be target element's previous sibling for 'beforebegin' case Note that this test has expected results now. > LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-insertAdjacentText-expected.txt:4 > +PASS Inserted text node should be target element's previous sibling for 'beforebegin' case Note that this test has expected results now.
Chris Dumez
Comment 5 2016-08-03 11:36:45 PDT
Comment on attachment 285249 [details] Patch Clearing flags on attachment: 285249 Committed r204090: <http://trac.webkit.org/changeset/204090>
Chris Dumez
Comment 6 2016-08-03 11:36:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.