Bug 160506

Summary: Duplicated code in DrawingAreaProxyImpl and CoordinatedDrawingAreaProxy
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, gyuyoung.kim, yoon, zan
Priority: P2 Keywords: Gtk
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Try to fix EFL build
none
Try to fix EFL build mcatanzaro: review+

Carlos Garcia Campos
Reported 2016-08-03 07:18:21 PDT
This is mostly the same than bug #159259, CoordinatedDrawingAreaProxy is just a copy paste of DrawingAreaProxyImpl with the non accelerated composited code path removed. We could reuse most of the code by subclassing.
Attachments
Patch (62.67 KB, patch)
2016-08-03 07:26 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Try to fix EFL build (62.68 KB, patch)
2016-08-03 07:43 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
Try to fix EFL build (62.72 KB, patch)
2016-08-03 07:48 PDT, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2016-08-03 07:26:49 PDT
Created attachment 285228 [details] Patch
Carlos Garcia Campos
Comment 2 2016-08-03 07:43:45 PDT
Created attachment 285229 [details] Try to fix EFL build
Carlos Garcia Campos
Comment 3 2016-08-03 07:48:30 PDT
Created attachment 285230 [details] Try to fix EFL build
Carlos Garcia Campos
Comment 4 2016-08-07 22:40:02 PDT
Committed r204249: <http://trac.webkit.org/changeset/204249>
Note You need to log in before you can comment on or make changes to this bug.