Bug 160502

Summary: WebRTC: OWR: Add support for the muted state in the mediaplayer
Product: WebKit Reporter: Alejandro G. Castro <alex>
Component: WebKitGTKAssignee: Alejandro G. Castro <alex>
Status: RESOLVED FIXED    
Severity: Normal CC: adam.bergkvist, bugs-noreply, pnormand
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch pnormand: review+

Alejandro G. Castro
Reported 2016-08-03 05:37:50 PDT
Currently the mediaplayer does not handle correctly the initial muted state of the tracks.
Attachments
Patch (10.98 KB, patch)
2016-08-03 05:59 PDT, Alejandro G. Castro 		pnormand: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alejandro G. Castro
Comment 1 2016-08-03 05:59:44 PDT
Created attachment 285221 [details] Patch
Eric Carlson
Comment 2 2016-08-03 08:37:08 PDT
Comment on attachment 285221 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285221&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:317 > + GST_WARNING("Unmutting a track with None type"); Nit: "Unmutting" isn't always correct.
Alejandro G. Castro
Comment 3 2016-08-04 02:27:47 PDT
Committed r204118: <http://trac.webkit.org/changeset/204118>
Alejandro G. Castro
Comment 4 2016-08-04 03:56:31 PDT
(In reply to comment #2) > Comment on attachment 285221 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=285221&action=review > > > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:317 > > + GST_WARNING("Unmutting a track with None type"); > > Nit: "Unmutting" isn't always correct. Right, fixed for the commit, thanks.
Note You need to log in before you can comment on or make changes to this bug.