Bug 160477 – Drop custom bindings code for HTMLSelectElement.remove()

• Component: Bindings
• Status: RESOLVED FIXED

[Chris Dumez]

Drop custom bindings code for HTMLSelectElement.remove() and use overloading instead.

[Chris Dumez]

Bindings look like:
EncodedJSValue JSC_HOST_CALL jsHTMLSelectElementPrototypeFunctionRemove(ExecState* state)
{
    size_t argsCount = std::min<size_t>(1, state->argumentCount());
    if (argsCount == 0) {
        return jsHTMLSelectElementPrototypeFunctionRemove1(state);
    }
    if (argsCount == 1) {
        JSValue distinguishingArg = state->uncheckedArgument(0);
        if (distinguishingArg.isObject() && asObject(distinguishingArg)->inherits(JSHTMLOptionElement::info()))
            return jsHTMLSelectElementPrototypeFunctionRemove3(state);
        if (distinguishingArg.isNumber())
            return jsHTMLSelectElementPrototypeFunctionRemove2(state);
        return jsHTMLSelectElementPrototypeFunctionRemove2(state);
    }
    return throwVMTypeError(state);
}

[Chris Dumez]

Created attachment 285162 [details]
Patch

[Chris Dumez]

Created attachment 285164 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 285164 [details]
Patch

Clearing flags on attachment: 285164

Committed r204064: <http://trac.webkit.org/changeset/204064>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.