| Summary: | Remove unused functions in URL | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Alex Christensen
2016-08-02 15:02:52 PDT
Created attachment 285144 [details]
Patch
Comment on attachment 285144 [details]
Patch
r=me
Do we have TestWebKitAPI tests for URL?
Attachment 285144 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 1 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > Do we have TestWebKitAPI tests for URL? We have a few such tests. Comment on attachment 285144 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=285144&action=review > Source/WebCore/platform/URL.h:-198 > - void print() const; This function is intended to be used in the debugger. How did you determine it was unused? (In reply to comment #5) > Comment on attachment 285144 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=285144&action=review > > > Source/WebCore/platform/URL.h:-198 > > - void print() const; > > This function is intended to be used in the debugger. How did you determine > it was unused? I searched for print() and found no call sites. I could leave it if you think it's useful https://trac.webkit.org/changeset/204046 I left the print function in. Not everybody debugs exactly like I do :) |