Bug 160439

Summary:

[JSC][ARM64] Fix branchTest32/64 taking an immediate as mask

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, cmarcelo, commit-queue, fpizlo, keith_miller, mark.lam, msaboff, saam

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Benjamin Poulain 2016-08-01 20:21:15 PDT

[JSC][ARM64] Fix branchTest32/64 taking an immediate as mask

Comment 1 Benjamin Poulain 2016-08-01 20:23:36 PDT

Created attachment 285066 [details]
Patch

Comment 2 Filip Pizlo 2016-08-01 21:39:24 PDT

Comment on attachment 285066 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285066&action=review

> Source/WTF/wtf/MathExtras.h:222
> +    typedef typename std::make_unsigned<T>::type UnsignedT;
>      unsigned result = 0;
>  
> -    while (value >>= 1)
> +    UnsignedT unsignedValue = static_cast<UnsignedT>(value);
> +    while (unsignedValue >>= 1)

lol

Comment 3 WebKit Commit Bot 2016-08-01 22:03:46 PDT

Comment on attachment 285066 [details]
Patch

Clearing flags on attachment: 285066

Committed r204009: <http://trac.webkit.org/changeset/204009>

Comment 4 WebKit Commit Bot 2016-08-01 22:03:51 PDT

All reviewed patches have been landed.  Closing bug.