Bug 160439 - [JSC][ARM64] Fix branchTest32/64 taking an immediate as mask
Summary: [JSC][ARM64] Fix branchTest32/64 taking an immediate as mask
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-08-01 20:21 PDT by Benjamin Poulain
Modified: 2016-08-01 22:03 PDT (History)
8 users (show)

See Also:

Attachments
Patch (4.63 KB, patch)
2016-08-01 20:23 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2016-08-01 20:21:15 PDT 
[JSC][ARM64] Fix branchTest32/64 taking an immediate as mask
Comment 1 Benjamin Poulain 2016-08-01 20:23:36 PDT 
Created attachment 285066 [details]
Patch
Comment 2 Filip Pizlo 2016-08-01 21:39:24 PDT 
Comment on attachment 285066 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=285066&action=review

> Source/WTF/wtf/MathExtras.h:222
> +    typedef typename std::make_unsigned<T>::type UnsignedT;
>      unsigned result = 0;
>  
> -    while (value >>= 1)
> +    UnsignedT unsignedValue = static_cast<UnsignedT>(value);
> +    while (unsignedValue >>= 1)

lol
Comment 3 WebKit Commit Bot 2016-08-01 22:03:46 PDT 
Comment on attachment 285066 [details]
Patch

Clearing flags on attachment: 285066

Committed r204009: <http://trac.webkit.org/changeset/204009>
Comment 4 WebKit Commit Bot 2016-08-01 22:03:51 PDT 
All reviewed patches have been landed.  Closing bug.