Summary: | Freeze all the DOMHTML* Objective-C bindings | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | darin | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Anders Carlsson
2016-08-01 13:55:02 PDT
Created attachment 285040 [details]
Patch
Comment on attachment 285040 [details]
Patch
rs=me
Committed r203988: <http://trac.webkit.org/changeset/203988> I just noticed that we are generating a lot of Objective-C bindings that then are not migrated by MigrateHeaders. I wonder if we can get away with just not generating any of those? (In reply to comment #4) > I just noticed that we are generating a lot of Objective-C bindings that > then are not migrated by MigrateHeaders. I wonder if we can get away with > just not generating any of those? Yeah, I've noticed that too. There are a couple of DOMEvent headers that aren't being installed, but they're used in Class kitClass(WebCore::Event* impl) I think we can simply fall back to DOMEvent for them. (In reply to comment #5) > (In reply to comment #4) > > I just noticed that we are generating a lot of Objective-C bindings that > > then are not migrated by MigrateHeaders. I wonder if we can get away with > > just not generating any of those? > > Yeah, I've noticed that too. There are a couple of DOMEvent headers that > aren't being installed, but they're used in > > Class kitClass(WebCore::Event* impl) > > I think we can simply fall back to DOMEvent for them. There are also CSS related classes that aren't installed but used in Class kitClass(WebCore::CSSRule* impl) and Class kitClass(WebCore::CSSValue* impl) We can probably get away with returning [DOMCSSRule class] and [DOMCSSValue class] respectively. There are also lots of others, like the Apple Pay ones. (In reply to comment #7) > There are also lots of others, like the Apple Pay ones. Yes, those aren't even built! |