Bug 160397

Summary: MediaResourceLoader::requestResource should take a ResourceRequest&& as input
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebCore Misc.Assignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, pnormand
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description youenn fablet 2016-08-01 01:05:05 PDT 
This would allow potentially removing a ResourceRequest copy.
Comment 1 youenn fablet 2016-08-01 01:06:45 PDT 
Created attachment 284989 [details]
Patch
Comment 2 youenn fablet 2016-08-01 03:19:09 PDT 
Created attachment 285000 [details]
Patch
Comment 3 WebKit Commit Bot 2016-08-01 03:20:54 PDT 
Attachment 285000 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/gstreamer/MainThreadNotifier.h:38:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 youenn fablet 2016-10-11 10:12:00 PDT 
Created attachment 291273 [details]
Patch
Comment 5 Alex Christensen 2016-10-11 12:23:12 PDT 
Comment on attachment 291273 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291273&action=review

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:583
> +        // FIXME: request should be moved for efficiency

I see no reason not to do that right now.
Comment 6 youenn fablet 2016-10-11 23:05:48 PDT 
Comment on attachment 291273 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291273&action=review

>> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:583
>> +        // FIXME: request should be moved for efficiency
> 
> I see no reason not to do that right now.

request cannot be moved currently as it is a const.
This is a result of priv->notifier.notify taking a std::function.
Comment 7 WebKit Commit Bot 2016-10-11 23:29:11 PDT 
Comment on attachment 291273 [details]
Patch

Clearing flags on attachment: 291273

Committed r207190: <http://trac.webkit.org/changeset/207190>
Comment 8 WebKit Commit Bot 2016-10-11 23:29:15 PDT 
All reviewed patches have been landed.  Closing bug.