Bug 160391

Summary: [GTK] Document how to initialize WebKitFaviconDatabase
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: WebKitGTKAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, cgarcia, commit-queue, gustavo, mcatanzaro, mrobinson
Priority: P2    
Version: Other   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch none

Michael Catanzaro
Reported 2016-07-31 13:17:03 PDT
webkit_favicon_database_get_favicon_finish() can return WEBKIT_FAVICON_DATABASE_ERROR_NOT_INITIALIZED but the only documentation on how to avoid this is in webkit_web_context_set_favicon_database_directory(), which is not mentioned anywhere in the WebKitFaviconDatabase documentation.
Attachments
Patch (1.79 KB, patch)
2016-08-02 20:40 PDT, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2016-08-02 20:40:28 PDT
Created attachment 285188 [details] Patch
WebKit Commit Bot
Comment 2 2016-08-02 20:46:33 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
WebKit Commit Bot
Comment 3 2016-08-03 07:36:58 PDT
Comment on attachment 285188 [details] Patch Clearing flags on attachment: 285188 Committed r204080: <http://trac.webkit.org/changeset/204080>
WebKit Commit Bot
Comment 4 2016-08-03 07:37:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.