Bug 160391 - [GTK] Document how to initialize WebKitFaviconDatabase
Summary: [GTK] Document how to initialize WebKitFaviconDatabase
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-31 13:17 PDT by Michael Catanzaro
Modified: 2016-08-03 07:37 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.79 KB, patch)
2016-08-02 20:40 PDT, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2016-07-31 13:17:03 PDT 
webkit_favicon_database_get_favicon_finish() can return WEBKIT_FAVICON_DATABASE_ERROR_NOT_INITIALIZED but the only documentation on how to avoid this is in webkit_web_context_set_favicon_database_directory(), which is not mentioned anywhere in the WebKitFaviconDatabase documentation.
Comment 1 Michael Catanzaro 2016-08-02 20:40:28 PDT 
Created attachment 285188 [details]
Patch
Comment 2 WebKit Commit Bot 2016-08-02 20:46:33 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 WebKit Commit Bot 2016-08-03 07:36:58 PDT 
Comment on attachment 285188 [details]
Patch

Clearing flags on attachment: 285188

Committed r204080: <http://trac.webkit.org/changeset/204080>
Comment 4 WebKit Commit Bot 2016-08-03 07:37:02 PDT 
All reviewed patches have been landed.  Closing bug.