Bug 160388

Summary: AX: Add a check for touch event listener on iOS accessibility object
Product: WebKit Reporter: Nan Wang <n_wang>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, n_wang, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
patch
none
patch none

Nan Wang
Reported 2016-07-31 02:28:34 PDT
Expose the check on the wrapper object so that we can handle simulating the touch on iOS.
Attachments
patch (9.41 KB, patch)
2016-07-31 02:47 PDT, Nan Wang 		no flags
DetailsFormatted DiffDiff
patch (9.39 KB, patch)
2016-07-31 11:33 PDT, Nan Wang 		no flags
DetailsFormatted DiffDiff
patch (9.34 KB, patch)
2016-07-31 11:40 PDT, Nan Wang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-07-31 02:28:45 PDT
<rdar://problem/27629346>
Nan Wang
Comment 2 2016-07-31 02:47:33 PDT
Created attachment 284963 [details] patch
chris fleizach
Comment 3 2016-07-31 11:01:05 PDT
Comment on attachment 284963 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=284963&action=review > Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm:89 > + return false; Will this also take care of the case where the listener is on a parent node?
Nan Wang
Comment 4 2016-07-31 11:33:25 PDT
Created attachment 284966 [details] patch update from review
Nan Wang
Comment 5 2016-07-31 11:40:37 PDT
Created attachment 284967 [details] patch better styling
chris fleizach
Comment 6 2016-07-31 12:01:06 PDT
Comment on attachment 284967 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=284967&action=review > Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm:88 > + if (node->hasEventListeners(eventNames().touchstartEvent) || node->hasEventListeners(eventNames().touchendEvent)) We may have code for this already. Can you do a search for ontouchstart and see if there's something in ax alread
Nan Wang
Comment 7 2016-07-31 12:29:07 PDT
Comment on attachment 284967 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=284967&action=review >> Source/WebCore/accessibility/ios/AccessibilityObjectIOS.mm:88 >> + if (node->hasEventListeners(eventNames().touchstartEvent) || node->hasEventListeners(eventNames().touchendEvent)) > > We may have code for this already. Can you do a search for ontouchstart and see if there's something in ax alread I searched ontouchstart, ontouchend, touchstart and touchend. And there's no related accessibility code.
WebKit Commit Bot
Comment 8 2016-07-31 13:04:12 PDT
Comment on attachment 284967 [details] patch Clearing flags on attachment: 284967 Committed r203955: <http://trac.webkit.org/changeset/203955>
WebKit Commit Bot
Comment 9 2016-07-31 13:04:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.