Bug 160381

Summary:

Assertion failure while setting the length of an ArrayClass array.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, buildbot, commit-queue, fpizlo, ggaren, keith_miller, msaboff, rniwa, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	buildbot: commit-queue-
Archive of layout-test-results from ews100 for mac-yosemite	none
Archive of layout-test-results from ews114 for mac-yosemite	none
proposed patch: with rebased test result.	none

Description Mark Lam 2016-07-30 09:19:11 PDT

When setting large length values, we're currently treating ArrayClass as a ContiguousIndexingType array.  This results in an assertion failure.

Comment 1 Mark Lam 2016-07-30 09:20:34 PDT

<rdar://problem/27328703>

Comment 2 Mark Lam 2016-07-30 09:31:11 PDT

Created attachment 284943 [details]
proposed patch.

Comment 3 Build Bot 2016-07-30 10:18:36 PDT

Comment on attachment 284943 [details]
proposed patch.

Attachment 284943 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1780339

New failing tests:
platform/mac/fast/dom/wrapper-classes-objc.html

Comment 4 Build Bot 2016-07-30 10:18:39 PDT

Created attachment 284945 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 5 Build Bot 2016-07-30 10:28:11 PDT

Comment on attachment 284943 [details]
proposed patch.

Attachment 284943 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1780350

New failing tests:
platform/mac/fast/dom/wrapper-classes-objc.html

Comment 6 Build Bot 2016-07-30 10:28:14 PDT

Created attachment 284946 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Comment 7 Mark Lam 2016-07-30 14:12:19 PDT

Created attachment 284954 [details]
proposed patch: with rebased test result.

Comment 8 WebKit Commit Bot 2016-07-30 18:09:53 PDT

Comment on attachment 284954 [details]
proposed patch: with rebased test result.

Clearing flags on attachment: 284954

Committed r203952: <http://trac.webkit.org/changeset/203952>

Comment 9 WebKit Commit Bot 2016-07-30 18:09:58 PDT

All reviewed patches have been landed.  Closing bug.