Bug 160372
| Summary: | We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Miller <keith_miller> |
| Component: | Tools / Tests | Assignee: | Keith Miller <keith_miller> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | ap, benjamin, bshafiei, fpizlo, ggaren, lforschler, mark.lam, mcatanzaro, mitz, msaboff, saam, ysuzuki |
| Priority: | P2 | ||
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Keith Miller
Buckle your seatbelts, this is going to be a big patch.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Keith Miller
It's happening! I hope this doesn't break everything... I hope no one commits anything in JavaScriptCore or Tools for the next ~2 hours.
Keith Miller
Oh, well that was faster than I thought. I assumed that svn didn't do smart things with moving directories. That's a pleasant surprise.
mitz
Is this a duplicate of bug 160180?
Keith Miller
(In reply to comment #3)
> Is this a duplicate of bug 160180?
Looks like it. I'll mark the other one as a dup though.
Keith Miller
Landed in https://trac.webkit.org/r203972.
Keith Miller
*** Bug 160180 has been marked as a duplicate of this bug. ***
Michael Catanzaro
Just noticed this.
It might make sense to move TestWebKitAPI up to the toplevel as well? It doesn't make much sense to me to have LayoutTests and JSTests and ManualTests and PerformanceTests at the toplevel, but bury API tests under Tools. Thoughts?