Bug 160357

Summary: Refactor DFG::Node::hasLocal() to accessesStack()
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, sbarati
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 160355    
Attachments:
Description Flags
Patch fpizlo: review+

Description Michael Saboff 2016-07-29 14:24:44 PDT
The Node class currently has two accessors, hasVariableAccessData() and hasLocal() that provide the same answer.  As part of the work for <https://bugs.webkit.org/show_bug.cgi?id=160355> - "JSVALUE64: Pass arguments in platform argument registers when making JavaScript calls", there is need for distinct accessors.  One of those accessors is needed to answer the question: "Does this node have a reference to a VariableAccessData object?".  A second accessor is needed to answer the question: "Does this node read/write the stack?".  That second question implies the need for such a node to have a reference to the appropriate VariableAccessData object, but within the DFG and FTL tier asserts a much stronger fact about the node.

This patch is for the work to refactor hasLocal() to accessesStack().
Comment 1 Michael Saboff 2016-07-29 14:41:43 PDT
Created attachment 284903 [details]
Patch
Comment 2 Filip Pizlo 2016-07-29 14:46:48 PDT
Comment on attachment 284903 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284903&action=review

> Source/JavaScriptCore/ChangeLog:14
> +        The hasVariableAccessData() check now iplies no more than the node has a

*implies
Comment 3 Michael Saboff 2016-07-29 15:05:17 PDT
Committed r203923: <http://trac.webkit.org/changeset/203923>