Bug 160353

Summary: [iOS] HTMLMediaElement::updateVolume() calls MediaPlayer::volume() on null media player
Product: WebKit Reporter: Daniel Bates <dbates>
Component: MediaAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, jer.noble
Priority: P2 Keywords: PlatformOnly
Version: WebKit Local Build   
Hardware: iPhone / iPad   
OS: iOS 9.3   
Attachments:
Description Flags
Stack trace
none
Patch
eric.carlson: review+, buildbot: commit-queue-
Archive of layout-test-results from ews125 for ios-simulator-wk2 none

Description Daniel Bates 2016-07-29 12:56:13 PDT
The test media/video-muted-after-setting-page-muted-state.html crashes when run in WebKitTestRunner.
Comment 2 Daniel Bates 2016-07-29 12:59:16 PDT
m_player can be nullptr at <https://trac.webkit.org/browser/trunk/Source/WebCore/html/HTMLMediaElement.cpp?rev=203917#L4821>.
Comment 3 Daniel Bates 2016-07-29 13:01:01 PDT
(In reply to comment #2)
> m_player can be nullptr at
> <https://trac.webkit.org/browser/trunk/Source/WebCore/html/HTMLMediaElement.
> cpp?rev=203917#L4821>.

Notice that below this iOS-specific code we bail out early if m_player is nullptr, <https://trac.webkit.org/browser/trunk/Source/WebCore/html/HTMLMediaElement.cpp?rev=203917#L4827>.
Comment 4 Daniel Bates 2016-07-29 13:03:51 PDT
(In reply to comment #3)
> (In reply to comment #2)
> > m_player can be nullptr at
> > <https://trac.webkit.org/browser/trunk/Source/WebCore/html/HTMLMediaElement.
> > cpp?rev=203917#L4821>.
> 
> Notice that below this iOS-specific code we bail out early if m_player is
> nullptr,
> <https://trac.webkit.org/browser/trunk/Source/WebCore/html/HTMLMediaElement.
> cpp?rev=203917#L4827>.

err, this code is in a #else-clause

For some reason we seem to expect that m_player is non-null for iOS.
Comment 5 Daniel Bates 2016-07-29 13:17:59 PDT
Created attachment 284896 [details]
Patch
Comment 6 Eric Carlson 2016-07-29 13:21:11 PDT
Comment on attachment 284896 [details]
Patch

Thanks Dan!
Comment 7 Build Bot 2016-07-29 16:05:39 PDT
Comment on attachment 284896 [details]
Patch

Attachment 284896 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1775781

New failing tests:
media/track/track-remove-quickly.html
Comment 8 Build Bot 2016-07-29 16:05:42 PDT
Created attachment 284909 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.5
Comment 9 Daniel Bates 2016-07-29 17:12:41 PDT
(In reply to comment #7)
> Comment on attachment 284896 [details]
> Patch
> 
> Attachment 284896 [details] did not pass ios-sim-ews (ios-simulator-wk2):
> Output: http://webkit-queues.webkit.org/results/1775781
> 
> New failing tests:
> media/track/track-remove-quickly.html

This test failure is not related to this change and is covered by bug #160367.
Comment 10 Daniel Bates 2016-07-29 17:15:08 PDT
Committed r203930: <http://trac.webkit.org/changeset/203930>