Bug 160333

Summary: Ignore most check-webkit-style checks for ANGLE project
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: Tools / TestsAssignee: David Kilzer (:ddkilzer) <ddkilzer>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, achristensen, commit-queue, dbates, dino, glenn, lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=160332
Attachments:
Description Flags
Patch v1 none

David Kilzer (:ddkilzer)
Reported 2016-07-28 22:39:40 PDT
The ANGLE project source does not match WebKit style. Instead, we preserve it so that merging upstream changes is easier. For this reason, we should relax what check-webkit-style accepts to avoid the horror of Bug 160332 Comment #3.
Attachments
Patch v1 (1.25 KB, patch)
2016-07-28 22:46 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2016-07-28 22:46:00 PDT
Created attachment 284848 [details] Patch v1
Aakash Jain
Comment 2 2016-07-29 07:02:24 PDT
unofficial r+
Daniel Bates
Comment 3 2016-07-29 18:05:39 PDT
Comment on attachment 284848 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=284848&action=review > Tools/ChangeLog:11 > + - No carriage returns (DOS line endings). Eww :(
WebKit Commit Bot
Comment 4 2016-07-29 18:26:46 PDT
Comment on attachment 284848 [details] Patch v1 Clearing flags on attachment: 284848 Committed r203936: <http://trac.webkit.org/changeset/203936>
WebKit Commit Bot
Comment 5 2016-07-29 18:26:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.